-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7475] - Add Switch Account button to Account Landing page #10052
upcoming: [M3-7475] - Add Switch Account button to Account Landing page #10052
Conversation
9288741
to
0d33960
Compare
@@ -55,6 +55,9 @@ describe('SwitchAccountDrawer', () => { | |||
|
|||
it('should display a list of child accounts', async () => { | |||
server.use( | |||
rest.get('*/account/users/*', (req, res, ctx) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fix here - noticed that I hadn't mocked this request and so if the mock endpoint were to change in user_type
in serverHandlers.ts
, this test would fail.
…r parent and proxy users
0d33960
to
be46234
Compare
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Switch Account" button visible for parent & proxy users ✅
Drawer for parent user lists child accounts ✅
Drawer for proxy user lists child accounts & has a link to switch back ✅
Improved tablet/mobile view ✅
Description 📝
This PR adds a convenient "Switch Account" button to the Account Landing page to allow an alternative and efficient way (aside from the user menu) to access the account switching drawer.
Changes 🔄
Preview 📷
Video
Screen.Recording.2024-01-10.at.10.48.49.AM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
yarn dev
.Verification steps
(How to verify changes)
user_type
is parent.)serverHandlers.ts
and edit theaccount/users/:user
request to the following in order to mock a proxy user:As an Author I have considered 🤔
Check all that apply