upcoming: [M3-7670] - Add and handle ACLB Account Capability #10098
Conversation
bnussman-akamai
added
Work in Progress
ACLB
| environmentVar: boolean, | ||
| capabilities: AccountCapability[] | ||
| ) => { | ||
| return environmentVar || capabilities.indexOf(featureName) > -1; |
There was a problem hiding this comment.
capabilities.indexOf(featureName) > -1 is savage. I wonder if includes did not exist when this was written 😅
There was a problem hiding this comment.
I de-ramda-ifyed this and tried to make the comment more useful.
There was a problem hiding this comment.
I'd been confused by isFeatureEnabled before too. My past, present, and future self thanks you for documenting this function for better clarity. 🙌🏼
There was a problem hiding this comment.
Because I de-ramda-ifyed this function, this test needed updating.
I tried to clean up this test and make it more straightforward. Previously it was saying all kinds of irrelevant stuff like EAP and beta_programs
bnussman-akamai
requested review from
mjac0bs and
carrillo-erik
and removed request for
a team
There was a problem hiding this comment.
I'd been confused by isFeatureEnabled before too. My past, present, and future self thanks you for documenting this function for better clarity. 🙌🏼
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
|
Coverage Report: ✅ |
| ); | ||
|
|
||
| return { isACLBEnabled }; | ||
| }; |
There was a problem hiding this comment.
I like this, should be make this a pattern to follow?
There was a problem hiding this comment.
I like it! It's a nice simple abstraction. I did it just incase we need to change how isACLBEnabled is determined
jaalah-akamai
added
Approved
Description 📝
This PR adds
Akamai Cloud Load Balancerto account capabilities so that we can conditionally enable the feature for some users during the closed beta.Changes 🔄
Akamai Cloud Load Balancerto account capabilitiesHow to test 🧪
Prerequisites
aclbtag to your account in the dev environment (ask me in Slack for more detailed instructions on how to do this)Verification steps
In summary, ACLB should only be visible if the
aglbfeature flag is on or you have theaclbtag on your accountAs an Author I have considered 🤔