-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [UIE-7292] - update scale-up to resize #10193
change: [UIE-7292] - update scale-up to resize #10193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more places we can update:
@@ -85,7 +85,7 @@ export const PlanContainer = (props: Props) => { | |||
// DC Dynamic price logic - DB creation and DB scale up flows are currently out of scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// DC Dynamic price logic - DB creation and DB scale up flows are currently out of scope | |
// DC Dynamic price logic - DB creation and DB resize flows are currently out of scope |
Also don't forget to add a changeset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change 👏🏼
Will the API rename the database_scale
Account Event to database_resize
? I think this change should be made because this feature hasn't launched yet and we don't want to be stuck with this inconsistency for the rest of time
e172bc1
to
9707ab5
Compare
We may need a changeset for the APIv4 package, same command as before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good!
Can we change file names like DatabaseScaleUp.tsx
to DatabaseResize.tsx
and also variables inside that file to use "Resize" instead of "ScaleUp".
Once we get this consistency, I think this PR will be good to go!
Coverage Report: ✅ |
@bnussman-akamai , DatabaseScaleUp.tsx and all variables related to "scale up" renamed to "resize" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for you addressing all of that feedback! All checks passed!
Description 📝
Updated "Scaled-Up" to "Resize"
Changes 🔄
Updated "Scaled-Up" to "Resize" within Scale Up tab in the Database Cluster
How to test 🧪
Open application, navigate to /databases, select the database cluster.
See that tab is now "Resize" instead of "Scale up". The text "scale up" and buttons name also changed to "resize" in this tab section