test: [M3-7557] - remove console logs from e2e tests #10506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureLatte
requested review from
jdamore-linode,
carrillo-erik and
cliu-akamai
and removed request for
a team
AzureLatte
requested review from
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
| @@ -154,15 +127,6 @@ describe('longview', () => { | |||
| cy.findByText('Waiting for data...'); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| // Install Longview on Linode by SSHing into machine and executing cURL command. | |
| installLongview(linodeIp, linodePassword, installCommand); |
In this case we still want to call installLongview, we just don't want to log its output. (This is going to be moot soon thanks to M3-8107, but I'm not sure this test will pass reliably in the meantime without this)
There was a problem hiding this comment.
Thanks! I reverted the changes and put the installlongview() back.
jdamore-linode
approved these changes
May 23, 2024
dwiley-akamai
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Some of our Cypress tests have stray calls to console.log and similar functions (console.info, console.error, etc.), and these should be removed.
Changes 🔄
Remove console.log functions in the spec files (cypress/e2e/*/)
How to test 🧪
As an Author I have considered 🤔
Check all that apply