Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8013] - Upgrade to Cypress v13.11.0 #10548

Merged

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

This upgrades Cypress and related dependencies to their latest versions. Check out Cypress's changelog for a more detailed overview of the changes since 13.5, but I've noted some of the most noteworthy changes:

  • Improve type definitions for cy.wait() and cy.intercept() (see entry)
  • Support Vite 5 (this is especially relevant for test: [M3-5858] - Cypress component tests #10134) (see entry)
  • Fixes a regression introduced in 13.6 that would cause Cypress to crash mid-run; this had been previously blocking our upgrade (see entry)
  • Fixes a bug with cy.wait that sometimes causes an error to be thrown. We've been getting unexplained test failures that are similar to the error described in the related PR, so this upgrade may fix them (see entry)

Changes 🔄

List any change relevant to the reviewer.

  • Upgrades cypress to 13.11, and updates our Dockerfile accordingly
  • Upgrades cypress-axe to 1.5.x, cypress-real-events to 1.12.x, and installs the latest patch versions for @testing-library/cypress and cypress-file-upload

How to test 🧪

We can rely on CI for this. Because we're skipping several versions, I plan to run the pipeline several times to ensure there aren't any changes that might impact our test stability.

@jdamore-linode jdamore-linode self-assigned this Jun 5, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner June 5, 2024 20:09
@jdamore-linode jdamore-linode requested review from mjac0bs and abailly-akamai and removed request for a team June 5, 2024 20:09
Copy link

github-actions bot commented Jun 5, 2024

Coverage Report:
Base Coverage: 82.35%
Current Coverage: 82.35%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe!

The CI run is passing and I kicked Cypress off locally as well to run just a few tests and confirm I had no issues. All looks good.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Jun 6, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seeing happy tests - 🚢

@jdamore-linode jdamore-linode merged commit 7124a92 into linode:develop Jun 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants