feat: [M3-7948] - Add Region filtering to Linodes landing table #10639

hana-akamai · 2024-07-02T17:27:22Z

Description 📝

Add support for region filtering in the Linodes landing table for Gecko LA. Region filter is saved in local storage similar to the "Show X" dropdown.

Changes 🔄

List any change relevant to the reviewer.

Add site_type to the linode instance type
Removed edge references where possible
Add region filter dropdown to the Linodes landing table

Preview 📷

(ip address has been redacted)

Screen.Recording.2024-10-03.at.1.51.32.PM.mov

How to test 🧪

Verification steps

All should display all Linodes (core and distributed regions)
Core should only display Linodes in core regions
Distributed should only display Linodes in distributed regions
Ensure sorting, summary, and tag view still work as normal
Navigate to another page and go back to the Landing page, the region selection should stay the same

As an Author I have considered 🤔

Check all that apply

…ng-table

github-actions · 2024-07-16T21:50:04Z

Coverage Report: ✅
Base Coverage: 87.22%
Current Coverage: 87.23%

mjac0bs

x-filter in mock requests looks good and so does the persistence of the selection.

packages/api-v4/src/linodes/types.ts

packages/manager/src/features/Linodes/LinodesLanding/DisplayLinodes.tsx

packages/manager/src/features/Linodes/LinodesLanding/ListView.tsx

mjac0bs

Thanks for the changes! All as a default is great, card view looks good, and putting the region type filter in its own component is clean.

Let's get the merge conflict resolved and make sure CI passes. And I think we do actually need to extend the width of the autocomplete / add padding after all. The checkmark is too close to the selection:

…ng-table

…onSite`

hana-akamai · 2024-10-03T17:44:51Z

packages/manager/src/features/Linodes/LinodesLanding/DisplayGroupedLinodes.tsx

+        {isGeckoLAEnabled && (
+          <Paper sx={{ padding: 1 }}>
+            <RegionTypeFilter handleRegionFilter={handleRegionFilter} />
+          </Paper>
+        )}


This was the main change

hana-akamai · 2024-10-03T17:47:13Z

packages/manager/src/features/Linodes/LinodesLanding/LinodesLanding.tsx

@@ -241,7 +247,7 @@ class ListLinodes extends React.Component<CombinedProps, State> {
      return <CircleProgress />;
    }

-    if (this.props.linodesData.length === 0) {
+    if (totalNumLinodes === 0 && linodesData.length === 0) {


We can't just rely on the length of linodesData because the 0 could be coming from filtered data and the user could have still have linodes

mjac0bs

UI: I was seeing a minor issue when one of the categories has no Linodes, Summary View is selected, and we are not grouping by tags. Can we add a consistent amount of spacing before the "No items to display"?

Code: Removal of edge looked good. Saw just a few nits.

Screen.Recording.2024-10-03.at.3.43.04.PM.mov

packages/api-v4/.changeset/pr-10639-added-1721317037923.md

packages/manager/src/features/Linodes/LinodesLanding/DisplayGroupedLinodes.tsx

packages/manager/src/features/Linodes/LinodesLanding/DisplayLinodes.tsx

bnussman-akamai

Looks good!

I wonder if we should add some kind of small loading state for when the user is switching between different region filters

mjac0bs

🚀

…ng-table

hana-akamai · 2024-10-07T18:05:31Z

@bnussman-akamai Good point, just realized we don't use the TableRowLoading component in LinodesLanding. I'll create a separate ticket to address that since it's going to require some code maneuvering

Edit: M3-8717

cypress · 2024-10-07T19:28:32Z

Cloud Manager E2E Run #6632

Run Properties: Failed #6632 • 5155c6a0af: feat: [M3-7948] - Add Region filtering to Linodes landing table (#10639)

Project	`Cloud Manager E2E`
Run status	`Failed #6632`
Run duration	`27m 29s`
Commit	`5155c6a0af: feat: [M3-7948] - Add Region filtering to Linodes landing table (#10639)`
Committer	`Hana Xu`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`4`
Pending	`2`
Skipped	`0`
Passing	`424`

Tests for review

cypress/e2e/core/placementGroups/delete-placement-groups.spec.ts • 1 failed test

View Output Video

Test		Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry		`Screenshots` `Video`

linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Linode Config management > End-to-End > Clones a config		`Screenshots` `Video`

linodes/create-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
... > creates a Shared CPU Linode		`Screenshots` `Video`

linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
rebuild linode > cannot rebuild a provisioning linode		`Screenshots` `Video`

volumes/delete-volume.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
volume delete flow > deletes a volume		`Screenshots` `Video`

…de#10639) ## Description 📝 Add support for region filtering in the Linodes landing table for Gecko LA. Region filter is saved in local storage similar to the "Show X" dropdown. ## Changes 🔄 List any change relevant to the reviewer. - Add `site_type` to the linode instance type - Removed `edge` references where possible - Add region filter dropdown to the Linodes landing table ## How to test 🧪 ### Verification steps - `All` should display all Linodes (core and distributed regions) - `Core` should only display Linodes in `core` regions - `Distributed` should only display Linodes in `distributed` regions - Ensure sorting, summary, and tag view still work as normal - Navigate to another page and go back to the Landing page, the region selection should stay the same

hana-akamai added 6 commits July 2, 2024 11:18

add site_type property to linode

32e2c9e

region filter ui

b69b5ee

add filtering logic and fix dark mode bg

cf374d9

save regionFilter value to local storage

33e258f

fix empty state filtering

837ed76

feature flag changes

9cfb8d7

hana-akamai added the Gecko LA Relating to Gecko LA label Jul 2, 2024

hana-akamai self-assigned this Jul 2, 2024

hana-akamai added 7 commits July 15, 2024 15:33

Merge branch 'develop' into M3-7948-add-region-filtering-linode-landi…

7bb5d41

…ng-table

move region filter logic to LinodesLandingWrapper for query

2e2eb58

eslint

2f610a9

Merge branch 'develop' into M3-7948-add-region-filtering-linode-landi…

093fd56

…ng-table

use api filter

0bc73da

fix sorting

7eef0c2

Added changeset: Add Region filtering to Linodes landing table

9b1b3b9

hana-akamai marked this pull request as ready for review July 16, 2024 21:13

hana-akamai requested a review from a team as a code owner July 16, 2024 21:13

hana-akamai requested review from mjac0bs and carrillo-erik and removed request for a team July 16, 2024 21:13

hana-akamai added the Work in Progress label Jul 16, 2024

remove old client side filtering logic

6693014

hana-akamai removed the Work in Progress label Jul 16, 2024

mjac0bs reviewed Jul 17, 2024

View reviewed changes

packages/api-v4/src/linodes/types.ts Outdated Show resolved Hide resolved

packages/manager/src/features/Linodes/LinodesLanding/DisplayLinodes.tsx Outdated Show resolved Hide resolved

packages/manager/src/features/Linodes/LinodesLanding/ListView.tsx Outdated Show resolved Hide resolved

hana-akamai added 2 commits July 18, 2024 11:37

Added changeset: site_type to the linode instance type

85f219a

address feedback

db5baec

mjac0bs self-requested a review July 18, 2024 16:40

mjac0bs reviewed Jul 18, 2024

View reviewed changes

Merge branch 'develop' into M3-7948-add-region-filtering-linode-landi…

a99e6af

…ng-table

jaalah-akamai self-requested a review October 2, 2024 19:10

hana-akamai added 5 commits October 2, 2024 16:15

fix empty state incorrectly displaying when filtered result is 0

a2fc3bb

address feedback

7ae27fb

fix region filter display for summary and group by tag

4425d45

mitigate region filter flickering

89ec8f2

remove edge references where possible

8ec3253

hana-akamai requested a review from a team as a code owner October 3, 2024 17:17

hana-akamai requested review from jdamore-linode and removed request for a team October 3, 2024 17:17

hana-akamai added 2 commits October 3, 2024 13:36

clean up

b142c07

Added changeset: edge type reference in LinodeTypeClass and `Regi…

24e7942

…onSite`

hana-akamai commented Oct 3, 2024

View reviewed changes

hana-akamai removed the Work in Progress label Oct 3, 2024

hana-akamai requested review from mjac0bs, bnussman-akamai and carrillo-erik October 3, 2024 17:54

fix distributed plan table

8edbf90

mjac0bs reviewed Oct 3, 2024

View reviewed changes

address feedback

d826dda

bnussman-akamai approved these changes Oct 4, 2024

View reviewed changes

mjac0bs self-requested a review October 4, 2024 18:14

mjac0bs approved these changes Oct 4, 2024

View reviewed changes

mjac0bs added the Approved Multiple approvals and ready to merge! label Oct 4, 2024

Merge branch 'develop' into M3-7948-add-region-filtering-linode-landi…

9a32119

…ng-table

hana-akamai merged commit 5155c6a into linode:develop Oct 7, 2024
20 checks passed

This was referenced Oct 10, 2024

Release v1.130.0 - release → staging #11087

Merged

Release v1.130.0- staging → master #11095

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-7948] - Add Region filtering to Linodes landing table #10639

feat: [M3-7948] - Add Region filtering to Linodes landing table #10639

hana-akamai commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

mjac0bs left a comment

mjac0bs left a comment •

edited

Loading

hana-akamai Oct 3, 2024

hana-akamai Oct 3, 2024

mjac0bs left a comment

bnussman-akamai left a comment

mjac0bs left a comment

hana-akamai commented Oct 7, 2024 •

edited

Loading

cypress bot commented Oct 7, 2024

feat: [M3-7948] - Add Region filtering to Linodes landing table #10639

feat: [M3-7948] - Add Region filtering to Linodes landing table #10639

Conversation

hana-akamai commented Jul 2, 2024 • edited Loading

Description 📝

Changes 🔄

Preview 📷

How to test 🧪

Verification steps

As an Author I have considered 🤔

github-actions bot commented Jul 16, 2024 • edited Loading

mjac0bs left a comment

Choose a reason for hiding this comment

mjac0bs left a comment • edited Loading

Choose a reason for hiding this comment

hana-akamai Oct 3, 2024

Choose a reason for hiding this comment

hana-akamai Oct 3, 2024

Choose a reason for hiding this comment

mjac0bs left a comment

Choose a reason for hiding this comment

bnussman-akamai left a comment

Choose a reason for hiding this comment

mjac0bs left a comment

Choose a reason for hiding this comment

hana-akamai commented Oct 7, 2024 • edited Loading

cypress bot commented Oct 7, 2024

Cloud Manager E2E Run #6632

Tests for review

hana-akamai commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

mjac0bs left a comment •

edited

Loading

hana-akamai commented Oct 7, 2024 •

edited

Loading