Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8305] - Display Endpoint Type alongside each endpoint hostname in Regions Column & Hostnames Drawers #10796

Conversation

harsh-akamai
Copy link
Contributor

Description 📝

As a customer, I want to see a list of endpoints, including the type of each endpoint (E0, E1, E2, E3) alongside each endpoint hostname, in various views related to S3 access keys in Cloud Manager. This will help me understand the endpoints in which each newly created or pre-existing S3 access key can be used.

Changes 🔄

  • Add "Action" Table Header for Actions Column
  • Endpoint Type Display in Regions Column
    • Display the type of each endpoint alongside each endpoint hostname in the existing Regions column of the top-level list of both pre-existing and new access keys.
  • (Drawer) Endpoint Type Display for Pre-existing Access Keys
    • Show the type of each endpoint alongside the endpoint hostname when displaying the full list of endpoint hostnames for a specific pre-existing access key.

Target release date 🗓️

N/A

Preview 📷

  • Access Key Landing Page
Before After
image image
  • Access Key Hostnames Drawer
Before After
image image

How to test 🧪

Prerequisites

  • Test all components for ObjectStorage buckets by toggling the OBJ Gen2 and the OBJ Multi-Cluster feature flags in dev environment

Reproduction steps

  • Go to serverHandler.ts file and under the *object-storage/keys route, add the endpoint_type key-value pair for all regions array

Verification steps

  • Turn on MSW
  • Navigate to the Access Keys Tab under Object Storage feature
  • You should see the last column of the top-level list having a "Actions" header.
  • You should find the Endpoint Type alongside each endpoint hostname in the existing Regions column of the top-level list of both pre-existing and new access keys.
  • On opening a hostname's Details drawer(only for keys in multiple regions), you should find the endpoint type alongside the endpoint hostname when displaying the full list of endpoint hostnames.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@harsh-akamai harsh-akamai self-assigned this Aug 19, 2024
@harsh-akamai harsh-akamai requested a review from a team as a code owner August 19, 2024 13:30
@harsh-akamai harsh-akamai requested review from carrillo-erik and coliu-akamai and removed request for a team August 19, 2024 13:30
Copy link

github-actions bot commented Aug 19, 2024

Coverage Report:
Base Coverage: 82.63%
Current Coverage: 82.63%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Don't forget to add a changeset yarn changeset Select manager > upcoming

@jaalah-akamai jaalah-akamai changed the title feat: [M3-8305] - Display Endpoint Type alongside each endpoint hostname in Regions Column & Hostnames Drawers upcoming: [M3-8305] - Display Endpoint Type alongside each endpoint hostname in Regions Column & Hostnames Drawers Aug 20, 2024
@harsh-akamai harsh-akamai force-pushed the feature/M3-8305-display-endpoint-types-for-access-keys-page-in-object-storage branch 2 times, most recently from 571a64e to c50f777 Compare August 20, 2024 06:53
@harsh-akamai harsh-akamai force-pushed the feature/M3-8305-display-endpoint-types-for-access-keys-page-in-object-storage branch from c50f777 to 532d05f Compare August 20, 2024 08:27
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ✅ You should see the last column of the top-level list having a "Actions" header.
  • ✅ You should find the Endpoint Type alongside each endpoint hostname in the existing Regions column of the top-level list of both pre-existing and new access keys.
  • ✅ On opening a hostname's Details drawer(only for keys in multiple regions), you should find the endpoint type alongside the endpoint hostname when displaying the full list of endpoint hostnames.

nice work! left one small, non-blocking optional comment

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 20, 2024
@jaalah-akamai jaalah-akamai merged commit fbf256a into linode:develop Aug 23, 2024
18 of 19 checks passed
@harsh-akamai harsh-akamai deleted the feature/M3-8305-display-endpoint-types-for-access-keys-page-in-object-storage branch August 26, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants