change: [M3-8075] - "Create Volume" button text changed to "Add Volume". #10808
Conversation
dchyrva-akamai
requested review from
jdamore-linode and
hana-akamai
and removed request for
a team
|
Hey @dchyrva, thanks for the contribution! It looks like this change caused a couple failures in our Cypress UI tests. The Cypress tests can be fixed here:
If you've already set up your environment for Cypress testing, you can verify that the tests pass by running this command while Cloud Manager is running locally: yarn cy:run -s "cypress/e2e/core/volumes/create-volume.smoke.spec.ts"Finally, you'll also want to add a changeset to your PR, which is essentially a small text file describing your change which we use when generating a changelogs for our releases. Step 7 of our PR submission docs goes into more detail, but you just need to run (We've also got some helpful guidelines for writing good changesets that I'd definitely encourage you to check out!) |
|
Coverage Report: ✅ |
dchyrva-akamai
force-pushed
the
feature/M3-8075
branch
from
2ea0202
to
d75c5db
Compare
dchyrva-akamai
requested review from
AzureLatte
and removed request for
a team
|
Hello @jdamore-linode, Thank you very much for your comments, they should be resolved now. However, I can see that "continuous-integration/cloud-manager-tests" step is still failing in the pipeline, Thank you very much in advance. |
hana-akamai
added
Approved
| // Click "Create Volume" button, fill out and submit volume create drawer form. | ||
| fbtClick('Create Volume'); | ||
| // Click "Add Volume" button, fill out and submit volume create drawer form. | ||
| cy.findByText('Add Volume').click(); |
There was a problem hiding this comment.
@dchyrva The reason for the failure was the same as create-volume.smoke.spec.ts, just happening in another test. This line was the fix. All tests related to this PR are passing locally now, so this should be set to merge.
The rest of the changes in the file are 1:1 swaps of some deprecated Cypress functions for newer ones.
Description 📝
"Create Volume" button text changed to "Add Volume".
Changes 🔄
"Create Volume" button text changed to "Add Volume".