Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8210] - Storybook nav organization POC #10809

Merged

Conversation

hana-linode
Copy link
Contributor

@hana-linode hana-linode commented Aug 21, 2024

Description 📝

POC to clean up the side nav in Storybook by reorganizing the hierarchy/component stories, and making the logo smaller

Changes 🔄

List any change relevant to the reviewer.

  • Smaller Akamai logo
  • Add Icons and Foundations section
  • Move Design System section to the top
  • Move relevant components to the new sections and consolidate related components into folders

Preview 📷

Before After
before.mov
after.mov

How to test 🧪

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-linode hana-linode marked this pull request as ready for review August 22, 2024 20:20
@hana-linode hana-linode requested a review from a team as a code owner August 22, 2024 20:20
@hana-linode hana-linode requested review from mjac0bs and jaalah-akamai and removed request for a team August 22, 2024 20:20
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, definitely feels like a better organized list to browse through if you're not already using search to look for something specific. 🚢

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Aug 23, 2024
@hana-linode hana-linode merged commit fa04d90 into linode:develop Aug 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants