Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: [M3-8463] - Add unit tests for CheckoutBar component #10818

Merged
merged 5 commits into from
Aug 26, 2024
Merged

test: [M3-8463] - Add unit tests for CheckoutBar component #10818

merged 5 commits into from
Aug 26, 2024

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Aug 23, 2024 •
edited
Loading

Description 📝

Unit test cases for CheckoutBar Component.

Changes 🔄

  • Add unit test cases for CheckoutBar Component.

Target release date 🗓️

N/A

How to test 🧪

Verification steps

  • Run yarn test src/components/CheckoutBar
  • Verify that all the test cases pass.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai requested a review from a team as a code owner August 23, 2024 06:24
@pmakode-akamai pmakode-akamai requested review from dwiley-akamai, abailly-akamai and coliu-akamai and removed request for a team August 23, 2024 06:24
@pmakode-akamai pmakode-akamai self-assigned this Aug 23, 2024
@pmakode-akamai pmakode-akamai added Unit tests Improves unit test coverage Ready for Review labels Aug 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 82.65%
Current Coverage: 82.65%

coliu-akamai
coliu-akamai reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Purvesh! Tests were passing 🎉 left a couple of comments

packages/manager/src/components/CheckoutBar/CheckoutBar.test.tsx Outdated Show resolved Hide resolved
packages/manager/src/components/CheckoutBar/CheckoutBar.test.tsx Outdated Show resolved Hide resolved
@coliu-akamai coliu-akamai changed the title test: [M3-8463] - Add Test Cases for CheckoutBar Component test: [M3-8463] - Add unit tests for CheckoutBar component Aug 23, 2024
coliu-akamai
coliu-akamai approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes - approving! ✅

packages/manager/src/components/CheckoutBar/CheckoutBar.tsx Show resolved Hide resolved
@pmakode-akamai pmakode-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 23, 2024
abailly-akamai
abailly-akamai approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added coverage 👍

packages/manager/src/components/CheckoutBar/CheckoutBar.test.tsx Outdated Show resolved Hide resolved
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 23, 2024
dwiley-akamai
dwiley-akamai approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once the CheckoutBar.tsx conflict is resolved 👍🏾

@pmakode-akamai pmakode-akamai force-pushed the M3-8463-tests-for-checkoutbar-component branch from 623889c to 131480c Compare August 23, 2024 18:13
@pmakode-akamai pmakode-akamai merged commit 2e1fed9 into linode:develop Aug 26, 2024
19 checks passed
This was referenced Aug 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@coliu-akamai coliu-akamai coliu-akamai approved these changes

Assignees

@pmakode-akamai pmakode-akamai

Labels
Approved Multiple approvals and ready to merge! Unit tests Improves unit test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmakode-akamai @dwiley-akamai @abailly-akamai @coliu-akamai