fix: [M3-7305] - Correct Object Storage folder links containing special characters #10822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skulpok-akamai
requested review from
cpathipa and
AzureLatte
and removed request for
a team
bnussman-akamai
approved these changes
Aug 23, 2024
Comment on lines
22
to
23
| const { getByRole } = render( | ||
| wrapWithTheme( |
There was a problem hiding this comment.
You could use renderWithTheme here or even wrapWithTableBody in this case
There was a problem hiding this comment.
Thanks, I replaced it with wrapWithTableBody.
jaalah-akamai
approved these changes
Aug 23, 2024
|
Coverage Report: ✅ |
|
I just noticed that I have a wrong import for TableRowProps. I'm doing a commit with the corrected import. |
cpathipa
requested changes
Aug 26, 2024
packages/manager/src/features/ObjectStorage/BucketDetail/FolderTableRow.test.tsx
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketDetail/FolderTableRow.test.tsx
Outdated
Show resolved
Hide resolved
cpathipa
reviewed
Aug 27, 2024
| @@ -6,10 +6,9 @@ import { Link } from 'react-router-dom'; | |||
| import { EntityIcon } from 'src/components/EntityIcon/EntityIcon'; | |||
| import { Hidden } from 'src/components/Hidden'; | |||
| import { TableCell } from 'src/components/TableCell'; | |||
| import { TableRow } from 'src/components/TableRow'; | |||
| import { TableRow, TableRowProps } from 'src/components/TableRow'; | |||
There was a problem hiding this comment.
import { TableRow } from 'src/components/TableRow';
import type { TableRowProps } from 'src/components/TableRow';
cpathipa
approved these changes
Aug 28, 2024
bnussman-akamai
changed the title
…ion replaced with wrapWithTableBody
Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com>
…rTableRow.test.tsx Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com>
abailly-akamai
force-pushed
the
feature/M3-7305-directory-links-with-special-characters
branch
from
a6a3357
to
5a22cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Object Storage bucket folders containing URL special characters could not be opened. After the change, their links navigate to a correct location.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Any release
Preview 📷
How to test 🧪
When opened, the folder should contain Test.txt file.
As an Author I have considered 🤔
Check all that apply