fix: [M3-8492] - Create Linode Firewall warning not appearing #10838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
commented
Aug 26, 2024
There was a problem hiding this comment.
Use undefined instead of -1 when clearing the firewall field.
hkhalil-akamai
commented
Aug 26, 2024
Comment on lines
48
to
52
| <Button buttonType="outlined" onClick={onOpenAPIAwareness}> | ||
| <Button | ||
| buttonType="outlined" | ||
| disabled={disableSubmitButton} | ||
| onClick={onOpenAPIAwareness} | ||
| > |
There was a problem hiding this comment.
This matches the behavior from create v1.
There was a problem hiding this comment.
Should we be excluding this from the API/CLI payloads?
hkhalil-akamai
commented
Aug 26, 2024
Comment on lines
-26
to
-30
| useEffect(() => { | ||
| if (isNotNullOrUndefined(watchFirewall)) { | ||
| clearErrors('firewallOverride'); | ||
| } | ||
| }, [clearErrors, watchFirewall]); |
There was a problem hiding this comment.
I meant to delete this useEffect in an earlier PR.
hkhalil-akamai
commented
Aug 26, 2024
Comment on lines
-906
to
-908
| checkedFirewallAuthorizaton={ | ||
| this.state.checkedFirewallAuthorization | ||
| } |
There was a problem hiding this comment.
checkedFirewallAuthorization is now passed on this line.
hkhalil-akamai
commented
Aug 26, 2024
| checkedFirewallAuthorizaton: boolean; | ||
| checkedFirewallAuthorization: boolean; |
There was a problem hiding this comment.
Typo:
checkedFirewallAuthorization
^
hkhalil-akamai
requested review from
jdamore-linode and
bnussman-akamai
and removed request for
a team
Comment on lines
48
to
52
| <Button buttonType="outlined" onClick={onOpenAPIAwareness}> | ||
| <Button | ||
| buttonType="outlined" | ||
| disabled={disableSubmitButton} | ||
| onClick={onOpenAPIAwareness} | ||
| > |
There was a problem hiding this comment.
Should we be excluding this from the API/CLI payloads?
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Aug 28, 2024
abailly-akamai
approved these changes
Aug 28, 2024
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes a bug causing the Firewall warning to not appear after the user assigns and then clears the firewall select during the create flow.
Changes 🔄
firewall_idinterface inCreateLinodePayloadto not accept null values (i.e.,number | undefined)SelectFirewallPaneland associated types in Create v1 to useundefinedinstead of-1when the firewall field is cleareduseEffectTarget release date 🗓️
9/3
Preview 📷
Screen.Recording.2024-08-26.at.4.16.35.PM.mov
Screen.Recording.2024-08-26.at.4.35.26.PM.mov
Screen.Recording.2024-08-26.at.4.20.41.PM.mov
Screen.Recording.2024-08-26.at.4.22.39.PM.mov
How to test 🧪
Prerequisites
Enable Secure VM notices by adding
secure_vm_notices: 'always'in the preference editor.Reproduction steps
Verification steps