change: [M3-8439] - Tag form events in Linode Create v2 #10840

mjac0bs · 2024-08-26T21:30:13Z

Description 📝

This PR tags the UI elements from Linode Create v2 that were not shared with the v1 flow (which was tagged in #10722).

Changes 🔄

See #10722 for an overview how form events are handled.

Target release date 🗓️

9/3

Preview 📷

Screenshots of Main Create Flow Events

Component	Analytics Event

Current: Two step:



	VPC is selected: VPC is cleared:
	Firewall is selected: Firewall is cleared:

click 'Create Linode' without filling in required fields

Screenshots of PG Branch Flow Events

Component	Analytics Event

Screenshots of Firewall Branch Flow Events

Component	Analytics Event

Screenshots of VPC Branch Flow Events

Component	Analytics Event

How to test 🧪

Prerequisites

(How to setup test environment)

You must have the Adobe Analytics environment set in your .env.
Check out this PR, yarn dev, and in the browser console, type _satellite.setDebug(true).

Verification steps

(How to verify changes)

Below are the two color-coded keys for what events should be tagged in the flow. Please see the Preview section for the events and confirm they are firing as expected.

Main Flow	Branching Flows (Drawers)

As an Author I have considered 🤔

Check all that apply

mjac0bs

This PR adds form events that were in LCv1 but missing in LCv2. It does not go back and clean up LCv1 form events because those files will presumably be removed soon.

mjac0bs · 2024-08-26T23:02:50Z

packages/manager/src/components/SelectFirewallPanel/SelectFirewallPanel.tsx

Removed unused form events from this file because this component not just part of the Linode Create flow v1 (i.e. it will not be deleted soon).

mjac0bs · 2024-08-26T23:04:12Z

packages/manager/src/features/Linodes/LinodeCreatev2/TwoStepRegion.test.tsx

Added test coverage for the 'How Data Center Pricing Works' docs link because it was missing from the TwoStepRegion select before.

packages/manager/src/features/Linodes/LinodeCreatev2/TwoStepRegion.tsx

mjac0bs · 2024-08-26T23:07:51Z

packages/manager/src/features/Linodes/LinodeCreatev2/index.tsx

@@ -134,6 +143,38 @@ export const LinodeCreatev2 = () => {
    }
  };

+  const handleAnalyticsFormError = useCallback(


Ported over from LinodeCreateContainer and adapted slightly for how errors in LCv2 are handled. UX wants to track specific errors for now.

Optional: Could we extract out some of this logic into a hook or function to keep this file a bit cleaner?

I just don't want this file to spiral out of control and resemble Linode Create v1

Yeah, fair point, we don't want to creep back to LCv1. I moved this to a hook in bd72f50, though wasn't sure how best to unit test.

github-actions · 2024-08-26T23:25:21Z

Coverage Report: ✅
Base Coverage: 82.62%
Current Coverage: 82.73%

abailly-akamai

Looks good! seeing most events firing with proper tags for each create mode. ✅

A couple things are not firing on my end

region selection
plan selection

Am i missing something?

packages/manager/src/features/Linodes/LinodeCreatev2/Actions.tsx

packages/manager/src/features/Linodes/LinodeCreatev2/Details/PlacementGroupPanel.tsx

bnussman-akamai · 2024-08-27T14:00:51Z

packages/manager/src/features/Linodes/LinodeCreatev2/index.tsx

@@ -134,6 +143,38 @@ export const LinodeCreatev2 = () => {
    }
  };

+  const handleAnalyticsFormError = useCallback(


Optional: Could we extract out some of this logic into a hook or function to keep this file a bit cleaner?

I just don't want this file to spiral out of control and resemble Linode Create v1

mjac0bs · 2024-08-27T15:38:18Z

A couple things are not firing on my end

region selection

plan selection

Am i missing something?

@abailly-akamai Thanks for verifying!

For Region selection, you should be seeing the logged formStart event, even if the second message says something like "criteria not met". The first message is sufficient for confirming the event in CM; the second message has to do with whether this url has been configured for the formStart in the analytics backend. (I think they turned formStart events off on localhost to save some event calls when we went to prod with LCv1 last week.)

For Plan selection, you should not be seeing any form events, but you should be seeing a formInput event upon clicking the "Choosing a Plan" docs link. (There are actually two analytics events here; a custom event and a form event. Form event is in orange below.)

bnussman-akamai

Looks good on my end!

Nice job keeping things as clean as possible 🧼

abailly-akamai

Thx for the clarifications! PR is good to go from my end, thx for tackling this!

hana-akamai · 2024-08-27T16:12:23Z

I'm not seeing Firewall change/clear events 🤔

mjac0bs · 2024-08-27T16:18:29Z

I'm not seeing Firewall change/clear events 🤔

@hana-linode But you were seeing other events and just not the change/clear? That's odd. I just verified that I can see all the events in the Firewall panel, and this looks consistent across create flow tabs.

hana-akamai · 2024-08-27T16:33:08Z

@mjac0bs Yes, I'm seeing all other events

Screen.Recording.2024-08-27.at.12.30.36.PM.mov

hana-akamai

Turns out my Linode Create v2 flag was off 😅 . Seeing all the events now!

mjac0bs added 2 commits August 26, 2024 13:56

Add all form events to v2 except errors

75e194b

Add form error and form submit events

0cbf562

mjac0bs self-assigned this Aug 26, 2024

mjac0bs added 7 commits August 26, 2024 14:43

Clean up comments

96dd5f8

Add missing link and form event to TwoStepRegion; add test coverage

1d3c6a4

Add missing form event on Getting Started docs link

a4decc6

Clean up from LCv1

a35b51a

Fix Region, Plan, and CLI button events

defaeee

Fix double fire on Region; fix formSubmit on OS

ccab87d

Added changeset: Tag Linode Create v2 with form events

fd595c3

mjac0bs marked this pull request as ready for review August 26, 2024 23:00

mjac0bs requested a review from a team as a code owner August 26, 2024 23:00

mjac0bs requested review from hana-akamai and abailly-akamai and removed request for a team August 26, 2024 23:00

mjac0bs commented Aug 26, 2024

View reviewed changes

mjac0bs requested a review from bnussman-akamai August 26, 2024 23:13

mjac0bs added the Ready for Review label Aug 26, 2024

abailly-akamai reviewed Aug 27, 2024

View reviewed changes

packages/manager/src/features/Linodes/LinodeCreatev2/Actions.tsx Outdated Show resolved Hide resolved

bnussman-akamai reviewed Aug 27, 2024

View reviewed changes

mjac0bs added 2 commits August 27, 2024 07:19

Address feedback: remove spread and properly tag CLI button

03e134e

Address feedback: use hook to keep index file clean

bd72f50

bnussman-akamai approved these changes Aug 27, 2024

View reviewed changes

abailly-akamai approved these changes Aug 27, 2024

View reviewed changes

mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Aug 27, 2024

mjac0bs added the Analytics Relating to Analytics migration project or Adobe Analytics label Aug 27, 2024

hana-akamai approved these changes Aug 27, 2024

View reviewed changes

mjac0bs merged commit 0162e80 into linode:develop Aug 27, 2024
18 of 19 checks passed

This was referenced Aug 29, 2024

Release v1.127.0 - release → staging #10854

Merged

Release v1.127.0 - staging → master #10875

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change: [M3-8439] - Tag form events in Linode Create v2 #10840

change: [M3-8439] - Tag form events in Linode Create v2 #10840

mjac0bs commented Aug 26, 2024 •

edited

Loading

mjac0bs left a comment

mjac0bs Aug 26, 2024

mjac0bs Aug 26, 2024

mjac0bs Aug 26, 2024

bnussman-akamai Aug 27, 2024

mjac0bs Aug 27, 2024

github-actions bot commented Aug 26, 2024 •

edited

Loading

abailly-akamai left a comment

bnussman-akamai Aug 27, 2024

mjac0bs commented Aug 27, 2024 •

edited

Loading

bnussman-akamai left a comment

abailly-akamai left a comment

hana-akamai commented Aug 27, 2024

mjac0bs commented Aug 27, 2024

hana-akamai commented Aug 27, 2024

hana-akamai left a comment

change: [M3-8439] - Tag form events in Linode Create v2 #10840

change: [M3-8439] - Tag form events in Linode Create v2 #10840

Conversation

mjac0bs commented Aug 26, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

mjac0bs left a comment

Choose a reason for hiding this comment

mjac0bs Aug 26, 2024

Choose a reason for hiding this comment

mjac0bs Aug 26, 2024

Choose a reason for hiding this comment

mjac0bs Aug 26, 2024

Choose a reason for hiding this comment

bnussman-akamai Aug 27, 2024

Choose a reason for hiding this comment

mjac0bs Aug 27, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 26, 2024 • edited Loading

abailly-akamai left a comment

Choose a reason for hiding this comment

bnussman-akamai Aug 27, 2024

Choose a reason for hiding this comment

mjac0bs commented Aug 27, 2024 • edited Loading

bnussman-akamai left a comment

Choose a reason for hiding this comment

abailly-akamai left a comment

Choose a reason for hiding this comment

hana-akamai commented Aug 27, 2024

mjac0bs commented Aug 27, 2024

hana-akamai commented Aug 27, 2024

hana-akamai left a comment

Choose a reason for hiding this comment

mjac0bs commented Aug 26, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2024 •

edited

Loading

mjac0bs commented Aug 27, 2024 •

edited

Loading