fix: [M3-8467] - Improve validation rules for create bucket schema #10847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
requested review from
bnussman-akamai and
carrillo-erik
and removed request for
a team
|
cc @hkhalil-akamai @mjac0bs Thanks for change recommendations |
bnussman-akamai
approved these changes
Aug 28, 2024
Comment on lines
15
to
17
| .matches( | ||
| /^[a-z0-9].*[a-z0-9]$/, | ||
| 'Label must start and end with a letter or number.' |
There was a problem hiding this comment.
Could we somehow make matches check after the min length check?
I my opinion "d" does start and and end with a letter so I think showing Label must be between 3 and 63 characters. first would be slightly nicer.
There was a problem hiding this comment.
I was about to say the same. 😄 🧠
Screen.Recording.2024-08-28.at.9.56.48.AM.mov
There was a problem hiding this comment.
Much better now - thanks!
mjac0bs
approved these changes
Aug 28, 2024
Comment on lines
15
to
17
| .matches( | ||
| /^[a-z0-9].*[a-z0-9]$/, | ||
| 'Label must start and end with a letter or number.' |
There was a problem hiding this comment.
I was about to say the same. 😄 🧠
Screen.Recording.2024-08-28.at.9.56.48.AM.mov
mjac0bs
added
Approved
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Aug 28, 2024
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The API currently returns an error when creating buckets, incorrectly checking for 'name' instead of 'label'. While a fix for this issue is planned for the future, we can improve our validation in the interim.
Changes 🔄
Target release date 🗓️
N/A
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
-test,test--,test.-TestAs an Author I have considered 🤔
Check all that apply