-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: BucketRateLimitTable bug causing page crashes on Object Storage Bucket Create/Details drawer #10849
Conversation
<Radio | ||
checked={row.checked} | ||
disabled | ||
name="limit-selection" | ||
onChange={() => {}} | ||
value="2" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old props for the radio - I'm unsure if the BucketRateLimitTable on the Details/Create drawer will eventually become part of a form, but for now placing this back in so that the page doesn't crash when trying to view the drawers
…et Create and Bucket Details drawer
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @coliu-akamai, Thanks for the fix 👍, but I believe this will be addressed in PR #10857. As planned, we have decided to remove the react-hook-form logic from the BucketRateLimitTable
. You can refer to the PR description for more details.
Given that we already have the OBJ cleanup PR, I’m not sure if we still need this one 😬. What are your thoughts, @jaalah-akamai?
@pmakode-akamai thanks for pointing that out! Happy to close this PR then, since this one still has the react form logic. |
Thanks @coliu-akamai I'll include this PR in a future ticket since your work could be useful for whoever takes on this task later. |
Description 📝
Target release date 🗓️
n/a
How to test 🧪
Reproduction steps
Verification steps
yarn test BucketRateLimitTable.test.tsx
As an Author I have considered 🤔
Check all that apply