Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BucketRateLimitTable bug causing page crashes on Object Storage Bucket Create/Details drawer #10849

Closed
wants to merge 2 commits into from

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Aug 28, 2024

Description 📝

  • Quick fix to prevent the 'Oh snap' error from occurring due to no form context when on the Object Storage Create/Details drawer - this just restores the table's behavior to what it used to be on the Create/Details drawer

Target release date 🗓️

n/a

How to test 🧪

Reproduction steps

  • with MSW and OBJ Gen2 flag enabled, navigate to Object Storage landing page
    • Create Bucket drawer: select a region with endpoints (Seattle) and click either endpoint E2 or E2
    • Bucket details drawer: click on the details button for a bucket with endpoint type E2 or E3
  • oh snap'd

Verification steps

  • Verify page no longer crashes when opening up bucket details drawer and bucket create drawer for steps above
  • verify Bucket Properties page still works as expected
  • yarn test BucketRateLimitTable.test.tsx

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

Comment on lines +93 to +99
<Radio
checked={row.checked}
disabled
name="limit-selection"
onChange={() => {}}
value="2"
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old props for the radio - I'm unsure if the BucketRateLimitTable on the Details/Create drawer will eventually become part of a form, but for now placing this back in so that the page doesn't crash when trying to view the drawers

@coliu-akamai coliu-akamai marked this pull request as ready for review August 28, 2024 19:12
@coliu-akamai coliu-akamai requested a review from a team as a code owner August 28, 2024 19:12
@coliu-akamai coliu-akamai requested review from dwiley-akamai, hkhalil-akamai and jaalah-akamai and removed request for a team August 28, 2024 19:12
@coliu-akamai coliu-akamai changed the title fix: BucketRateLimitTable bug causing page crashes on Object Storage Create/Details drawer fix: BucketRateLimitTable bug causing page crashes on Object Storage Bucket Create/Details drawer Aug 28, 2024
@coliu-akamai coliu-akamai added Bug Fixes for regressions or bugs Ready for Review labels Aug 28, 2024
Copy link

Coverage Report:
Base Coverage: 82.73%
Current Coverage: 82.73%

@pmakode-akamai pmakode-akamai self-requested a review August 30, 2024 12:06
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coliu-akamai, Thanks for the fix 👍, but I believe this will be addressed in PR #10857. As planned, we have decided to remove the react-hook-form logic from the BucketRateLimitTable. You can refer to the PR description for more details.

Given that we already have the OBJ cleanup PR, I’m not sure if we still need this one 😬. What are your thoughts, @jaalah-akamai?

@coliu-akamai
Copy link
Contributor Author

coliu-akamai commented Aug 30, 2024

@pmakode-akamai thanks for pointing that out! Happy to close this PR then, since this one still has the react form logic.

@jaalah-akamai
Copy link
Contributor

Thanks @coliu-akamai I'll include this PR in a future ticket since your work could be useful for whoever takes on this task later.

@coliu-akamai coliu-akamai deleted the bucket-table-bug branch September 6, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants