Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change pageSize to page_size in api-v4 documentation #11129

Conversation

bnussman-akamai
Copy link
Member

Description 📝

How to test 🧪

  • Check doc for correctness

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Documentation Improving / adding to our documentation label Oct 21, 2024
@bnussman-akamai bnussman-akamai self-assigned this Oct 21, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner October 21, 2024 14:20
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and coliu-akamai and removed request for a team October 21, 2024 14:20
Copy link

github-actions bot commented Oct 21, 2024

Coverage Report:
Base Coverage: 87.05%
Current Coverage: 87.05%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Banks! 🚀
would this need a changeset?

@bnussman-akamai
Copy link
Member Author

Added! @coliu-akamai

@bnussman-akamai bnussman-akamai merged commit d0e1012 into linode:develop Oct 21, 2024
21 of 23 checks passed
Copy link

cypress bot commented Oct 21, 2024

Cloud Manager E2E    Run #6706

Run Properties:  status check passed Passed #6706  •  git commit d0e1012dae: docs: Change `pageSize` to `page_size` in `api-v4` documentation (#11129)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6706
Run duration 27m 35s
Commit git commit d0e1012dae: docs: Change `pageSize` to `page_size` in `api-v4` documentation (#11129)
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improving / adding to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] PageSize does not work on getLinodes
4 participants