refactor: [M3-8652] - TextField Component Cleanup - Part 1 #11134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
changed the title
jaalah-akamai
requested review from
cpathipa and
hkhalil-akamai
and removed request for
a team
jaalah-akamai
commented
Oct 22, 2024
| } | ||
| }; | ||
| }, | ||
| [min, max, type, onChange] |
There was a problem hiding this comment.
Only changes here were to wrap this in a useCallback
jaalah-akamai
commented
Oct 22, 2024
jaalah-akamai
commented
Oct 22, 2024
| {helperText} | ||
| </FormHelperText> | ||
| )} | ||
| {helperText && helperTextPosition === 'bottom' && ( |
There was a problem hiding this comment.
Cleaned up this condition by setting a default for the helperTextPosition
jaalah-akamai
commented
Oct 22, 2024
| @@ -17,7 +71,6 @@ export const Default: Story = { | |||
| noMarginTop: true, | |||
| placeholder: 'Placeholder', | |||
| }, | |||
| render: (args) => <TextField {...args} />, | |||
There was a problem hiding this comment.
render wasn't necessary for variants
hkhalil-akamai
approved these changes
Oct 23, 2024
|
Coverage Report: ❌ |
cpathipa
approved these changes
Oct 29, 2024
cpathipa
added
Approved
|
Flaky DB unit test: |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 26m 47s |
| Commit |
|
| Committer | Jaalah Ramos |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Goal is to eventually move this to
linode/uipackage, but a little cleanup was necessary.Changes 🔄
makeStylesforsxproponChangehandler in auseCallbackfor perfTarget release date 🗓️
N/A
Preview 📷
Should be no visual changes
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply