-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8754] - Add Alias Tokens to the Theme #11138
upcoming: [M3-8754] - Add Alias Tokens to the Theme #11138
Conversation
InteractionTypes as InteractionTypesLight, | ||
TypographyTypes, | ||
RadiusTypes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typography
and Radius
are the same for light/dark so simplified our Theme/ThemeOptions for now
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having things like theme.borderTokens
, theme.chartTokens
, I wonder if it would make sense to do something like theme.tokens.border
, theme.tokens.chart
@jaalah @harsh-akamai
@bnussman-akamai This is a good suggestion. Though it would require a change in the ui package (breakpoints.ts) I believe I will have to create a separate PR for a change in the ui package? |
d3bf46c
to
0dc11fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming that Cloud built using the new tokens. (The interaction.Background.Secondary
uses a darker shade of black in dark mode.)
Looks like there are merge conflicts to resolve in a few files, @harsh-akamai.
I also think we're going to want to be consistent with naming conventions. The following PRs (cc @pmakode-akamai , @zaenab-akamai) are using the previous method of naming with
@jaalah-akamai Do we want to proceed across the board with |
@harsh-akamai @bnussman-akamai @mjac0bs Let's do |
@mjac0bs Looks like there is no perfect replacement for |
Cloud Manager E2E Run #6774
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6774
|
Run duration | 26m 49s |
Commit |
28ad446c8d: upcoming: [M3-8754] - Add Alias Tokens to the Theme (#11138)
|
Committer | Harsh Shankar Rao |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
445
|
View all changes introduced in this branch ↗︎ |
Description 📝
Alias tokens should be available to components via
theme.*
Changes 🔄
accentTokens
actionTokens
backgroundTokens
borderTokens
contentTokens
elevationTokens
interactionTokens
typographyTokens
radiusTokens
Target release date 🗓️
10/24
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply