fix: [M3-8743] - fix aria label of action menu in IP address table row. #11167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasyed-akamai
requested review from
mjac0bs and
hana-akamai
and removed request for
a team
|
Coverage Report: ✅ |
hasyed-akamai
added
Ready for Review
Linodes
mjac0bs
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks for fixing this! Approving pending the minor comments I left are addressed.
I'd recommend that we also confirm the corrected aria label via the unit test for LinodeIPAddressRow.test.tsx using a getByLabelText for the action menu. (Banks made this improvement in a recent PR, but the PR was reverted for other reasons.)
...s/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeNetworkingActionMenu.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
| if (ipAddress && 'address' in ipAddress) { | ||
| return `Action menu for IP Address ${ipAddress.address}`; | ||
| } else { | ||
| return `Action menu for IP Address ${ipAddress?.range}`; |
There was a problem hiding this comment.
Can we make the ipAddress prop required on this component? That may allow us to remove this ? as well
There was a problem hiding this comment.
Change the ipAddress prop to required to remove the optional chaining ?
hana-akamai
approved these changes
Oct 28, 2024
hasyed-akamai
added
Approved
bnussman-akamai
approved these changes
Oct 29, 2024
...s/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeNetworkingActionMenu.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 04s |
| Commit |
|
| Committer | hasyed-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
To get a better understanding of the aria label of action menu in IP Address table. Here, we have make it human readable by adding address to the aria label.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply