fix: [M3-8802] - Object Storage landing page UI bugs #11187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
Bug
bnussman-akamai
requested review from
mjac0bs and
hana-akamai
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
requested review from
jdamore-linode
and removed request for
a team
hana-akamai
reviewed
Oct 30, 2024
hana-akamai
approved these changes
Nov 1, 2024
|
|
||
| return data?.map((eachKey: ObjectStorageKey, index) => ( | ||
| <AccessKeyTableRow | ||
| key={index} |
There was a problem hiding this comment.
Suggested change
| key={index} | |
| key={eachKey.id} |
There was a problem hiding this comment.
Great catch. Thank you!
|
👋🏼 It's me, hi, my PR just caused merge conflict problems. Thanks for resolving and I'll review this PR in after I take lunch. Looks like solid clean up! |
Cloud Manager UI test results🎉 445 passing tests on test run #10 ↗︎
|
mjac0bs
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
This looked really good! Styling at various screen sizes checked out and no regressions that I could find in functionality. Great attention to detail here - I don't know that I would have noticed the different background colors in hostnames copyable text field on my own. 🚀
mjac0bs
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 06s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes with Preview 📷
Fixed inconstant table background color on the Buckets landing page
Fixed broken loading state on Access Key landing page
Improved Access Keys landing page for small screen sizes 📱
I hid the "Hostnames" column on small screens, but added an action menu item so the user can still open and view the hostnames drawer
Removed "Actions" text in table column header
Fixed broken action menu spacing
Fixed multiple background colors in hostnames drawer
How to test 🧪
As an Author I have considered 🤔