feat: [M3-8883] - Use our search parser on Images Landing #11233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
hana-akamai and
abailly-akamai
and removed request for
a team
|
Coverage Report: ✅ |
abailly-akamai
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
This is great and a nice improvement 🎉 Left comments that should be addressed, but are non-blocking.
- confirmed search parity with search filter and global search ✅
- confirmed error handling is sound ✅
My only concern in general with the feature (not so now, cause not only is it a parity item but a considerable improvement) is how can we communicate this feature to the user knowing that:
- every endpoint has its quirks and may or may not support a variety of filters, including filter operators
- every endpoint has its own handling of errors (sometimes we'll get a proper 400 with a message, sometimes a 500)
This is going to be an intricate UI and I wonder if we should start thinking of a util that's going to help us generate this contextual help, taking as arguments the things it can and can't do (with which we could also perhaps return our own errors)
hana-akamai
approved these changes
Nov 13, 2024
packages/manager/src/features/Images/ImagesLanding/ImagesLanding.tsx
Outdated
Show resolved
Hide resolved
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/create-linode-region-select.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 24m 57s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
Nov 15, 2024
* initial work * make overriding contains filter shape more generic * make things more generic * allow underscore in seaches * allow `:` in searches * only disable retries if the user is searching * add changeset * add changeset * use `errorText` prop @hana-akamai * add comment to summarize what is filterable --------- Co-authored-by: Banks Nussman <banks@nussman.us>
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
Nov 15, 2024
* initial work * make overriding contains filter shape more generic * make things more generic * allow underscore in seaches * allow `:` in searches * only disable retries if the user is searching * add changeset * add changeset * use `errorText` prop @hana-akamai * add comment to summarize what is filterable --------- Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Search by
regionThis will help power users using Image Service Gen2
Note
Sadly does not support complex operations (
+or/+and) due to API limitations. Only available in dev right now.Search by
labeland/orsizeNote
Because the API returns size in MB, the user would have to search in MBs 🫤 Planning to bring this to UX, but not blocking in my opinion
Search by
tags(ortagbecause it is aliased)Adds a sustainable way to filter by tag 🎉
Note
Searching by tag is partially broken. See
ARB-5792How to test 🧪
As an Author I have considered 🤔