Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8903] - Improve Image Status Column #11257

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Nov 13, 2024

Description 📝

  • Improves the UI/UX of the status column on the Images Landing table 💾
  • Shows Image status of Available instead of overwritten value of Ready so that Cloud Manager is more similar to the API ✏️
  • Made Status Column consider region statuses (see preview)
  • Improved Image upload error state (see preview)

Preview 📷

Made Status Column consider region statuses

Before After
Screen.Recording.2024-11-13.at.5.02.14.PM.mov
Screen.Recording.2024-11-13.at.4.53.31.PM.mov

Improved Image Upload Failure

Before After
Screenshot 2024-11-13 at 6 03 39 PM Screenshot 2024-11-13 at 5 35 01 PM

How to test 🧪

  • Test various image actions (create, upload, replicate to different regions)
  • Verify all cypress and unit tests pass

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai self-assigned this Nov 13, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review November 14, 2024 15:02
@bnussman-akamai bnussman-akamai requested review from a team as code owners November 14, 2024 15:02
@bnussman-akamai bnussman-akamai requested review from AzureLatte, hana-akamai and harsh-akamai and removed request for a team November 14, 2024 15:02
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 445 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing445 Passing2 Skipped101m 33s

Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good!✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Relating to Images Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants