Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove 'MongoDB' from ClusterControl alt_description in Marketplace #9119

Merged
merged 1 commit into from
May 15, 2023

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented May 15, 2023

Description 📝

Brief description explaining the purpose of the changes
This is a follow up from #9081 because the alt_description still contained a reference to the app. This meant that ClusterControl came up in the search results if a user searched "MongoDB" (and would likely be read out via a screenreader, though I didn't confirm that).

Preview 📷

Before After
Screenshot 2023-05-15 at 11 25 20 AM Screenshot 2023-05-15 at 11 25 07 AM

How to test 🧪

  1. How to reproduce the issue (if applicable)?
    Test the marketplace search on staging and note that "ClusterControl" is returned as a search result if the user searches for "MongoDB".
  2. How to verify changes?
    Test the marketplace search on staging and note that no search results are returned as a search result if the user searches for "MongoDB".

@mjac0bs mjac0bs self-assigned this May 15, 2023
@mjac0bs mjac0bs merged commit abf4448 into linode:staging May 15, 2023
@cypress
Copy link

cypress bot commented May 15, 2023

1 flaky tests on run #3535 ↗︎

0 162 4 0 Flakiness 1

Details:

null
Project: Cloud Manager E2E Commit: c8efd44959
Status: Passed Duration: 15:12 💡
Started: May 15, 2023 8:21 PM Ended: May 15, 2023 8:36 PM
Flakiness  cypress/e2e/account/google-pay.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Google Pay > tests make payment flow - google pay Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants