-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-6727] β Include firewall field as part of Linode Create object #9453
Merged
dwiley-akamai
merged 17 commits into
linode:develop
from
dwiley-akamai:M3-6727-vpc-assorted-endpoints
Aug 24, 2023
Merged
feat: [M3-6727] β Include firewall field as part of Linode Create object #9453
dwiley-akamai
merged 17 commits into
linode:develop
from
dwiley-akamai:M3-6727-vpc-assorted-endpoints
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦s -- tweaks forthcoming
dwiley-akamai
added
Do Not Merge
@linode/api-v4
Changes are made to the @linode/api-v4 package
@linode/validation
Changes are made to the @linode/validation package
VPC
Relating to VPC project
labels
Jul 26, 2023
β¦ store linode label character requirements in a constant to prevent repetition
bnussman-akamai
approved these changes
Aug 23, 2023
coliu-akamai
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
A file I committed earlier, src/utilities/subnets.ts
, uses the old version of vpcsValidateIP
(inside the function validateSubnets
), so you may need to merge develop into your branch and fix that to avoid errors
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Multiple approvals and ready to merge!
@linode/api-v4
Changes are made to the @linode/api-v4 package
@linode/validation
Changes are made to the @linode/validation package
VPC
Relating to VPC project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
Add
firewall_id
toCreateLinodeRequest
interface andCreateLinodeSchema
to allow for assignment of a firewall during Linode creation. Also address a bit of feedback from #9418.Note: the back-end work has not been merged to dev at this time, so I placed a "Do Not Merge" label on this until it can be tested.Major Changes π
firewall_id
toCreateLinodeRequest
interfacefirewall_id
toCreateLinodeSchema
How to test π§ͺ
You can test this in alpha/dev via the cURL or the Linode CLI. Run something like this in the command line:
Upon executing successfully, you should see the newly-created linode in Cloud. On the Linode Details > Network tab, you can verify the firewall is assigned, and you can also check on the Firewall Details > Linodes tab.