Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-6727] – Include firewall field as part of Linode Create object #9453

Merged

Conversation

dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Jul 26, 2023

Description πŸ“

Add firewall_id to CreateLinodeRequest interface and CreateLinodeSchema to allow for assignment of a firewall during Linode creation. Also address a bit of feedback from #9418.

Note: the back-end work has not been merged to dev at this time, so I placed a "Do Not Merge" label on this until it can be tested.

Major Changes πŸ”„

  • Add firewall_id to CreateLinodeRequest interface
  • Add firewall_id to CreateLinodeSchema

How to test πŸ§ͺ

You can test this in alpha/dev via the cURL or the Linode CLI. Run something like this in the command line:

curl -X POST https://api.dev.linode.com/v4beta/linode/instances \
-H "Authorization: Bearer [INSERT YOUR TOKEN HERE]" -H "Content-type: application/json" \
-d '{ "type":"g6-standard-2", "region": "us-east", "label": "linode123", "firewall_id":[INSERT ID OF YOUR EXISTING FIREWALL HERE]}' | jq

Upon executing successfully, you should see the newly-created linode in Cloud. On the Linode Details > Network tab, you can verify the firewall is assigned, and you can also check on the Firewall Details > Linodes tab.

@dwiley-akamai dwiley-akamai added Do Not Merge @linode/api-v4 Changes are made to the @linode/api-v4 package @linode/validation Changes are made to the @linode/validation package VPC Relating to VPC project labels Jul 26, 2023
@dwiley-akamai dwiley-akamai self-assigned this Jul 26, 2023
@jaalah-akamai jaalah-akamai marked this pull request as draft July 26, 2023 19:36
@dwiley-akamai dwiley-akamai marked this pull request as ready for review August 21, 2023 19:45
… store linode label character requirements in a constant to prevent repetition
@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 23, 2023
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰

A file I committed earlier, src/utilities/subnets.ts, uses the old version of vpcsValidateIP (inside the function validateSubnets), so you may need to merge develop into your branch and fix that to avoid errors

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 23, 2023
@dwiley-akamai dwiley-akamai merged commit 0af88ff into linode:develop Aug 24, 2023
11 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-6727-vpc-assorted-endpoints branch August 24, 2023 21:37
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! @linode/api-v4 Changes are made to the @linode/api-v4 package @linode/validation Changes are made to the @linode/validation package VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants