Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: PR Template Updates #9769

Merged
merged 2 commits into from
Oct 9, 2023
Merged

change: PR Template Updates #9769

merged 2 commits into from
Oct 9, 2023

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Oct 6, 2023 •
edited
Loading

Description 📝

Changes 🔄

  • Fixes bullet points for the As an Author I have considered 🤔 section
  • Removes unnecessary <br>s

Preview 📷

Not sure now to best preview this

before after
Screenshot 2023-10-06 at 2 51 13 PM Screenshot 2023-10-06 at 2 50 56 PM

@bnussman-akamai bnussman-akamai added the Documentation Improving / adding to our documentation label Oct 6, 2023
@bnussman-akamai bnussman-akamai self-assigned this Oct 6, 2023
@bnussman-akamai bnussman-akamai marked this pull request as ready for review October 9, 2023 13:55
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner October 9, 2023 13:55
@bnussman-akamai bnussman-akamai requested review from mjac0bs and hana-akamai and removed request for a team October 9, 2023 13:55
abailly-akamai
abailly-akamai approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ty

@abailly-akamai
Copy link
Contributor

btw, "chore" isn't a thing anymore since we're complying to changeset types for commit messages for consistency.

@bnussman-akamai bnussman-akamai changed the title chore: PR Template Fixes change: PR Template Updates Oct 9, 2023
@bnussman-akamai bnussman-akamai merged commit c293284 into linode:develop Oct 9, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@jdamore-linode jdamore-linode jdamore-linode approved these changes

@mjac0bs mjac0bs Awaiting requested review from mjac0bs mjac0bs is a code owner automatically assigned from linode/frontend

@hana-akamai hana-akamai Awaiting requested review from hana-akamai hana-akamai is a code owner automatically assigned from linode/frontend

Assignees

@bnussman-akamai bnussman-akamai

Labels
Documentation Improving / adding to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @abailly-akamai @jdamore-linode @bnussman