Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [DBASS1-574] - Adding test coverage for disk metrics added to UI. #9833

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

sujai-git
Copy link
Contributor

Description 📝

Add test coverage to check disk metrics parameters.
Add test coverage for low disk size event.

Changes 🔄

Add new cypress assertions to check disk metrics parameters "Total disk size" and "Used disk size" added to the UI.
Add test coverage for low disk size event.

  • ...
  • ...

Preview 📷

Screenshot 2023-10-23 at 6 52 53 PM

How to test 🧪

yarn cy:run -s "cypress/e2e/core/databases/update-database.spec.ts"

yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/events.spec.ts"

@sujai-git sujai-git requested a review from a team as a code owner October 23, 2023 22:59
@sujai-git sujai-git requested review from jdamore-linode and cliu-akamai and removed request for a team October 23, 2023 22:59
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @sujai-git!

@jdamore-linode
Copy link
Contributor

Hey @sujai-git, next time you have a chance would you mind running the yarn changeset command and committing/pushing the results? We use that command to generate changesets which describe the changes present in develop and to generate the changelogs for our releases.

Feel free to reach out over Slack if you have any questions or if I can offer any clarification!

@sujai-git
Copy link
Contributor Author

Hey @sujai-git, next time you have a chance would you mind running the yarn changeset command and committing/pushing the results? We use that command to generate changesets which describe the changes present in develop and to generate the changelogs for our releases.

Feel free to reach out over Slack if you have any questions or if I can offer any clarification!

Sure. Thanks

@jdamore-linode jdamore-linode merged commit 5033391 into linode:develop Oct 26, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants