Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-7213] - DC Get Well endpoints, queries, and mock data #9860

Merged
merged 9 commits into from
Nov 1, 2023
Merged

upcoming: [M3-7213] - DC Get Well endpoints, queries, and mock data #9860

merged 9 commits into from
Nov 1, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 1, 2023 •
edited
Loading

Description 📝

  • Adds api-v4 endpoints and types for DC Get Well
  • Adds react queries and mock data for DC Get Well endpoints

How to test 🧪

This should have no impact (yet) on customer facing codebase.

Verification steps

  • Review endpoints, spelling, and types -- cross reference endpoints and types to API specification on internal ticket
  • If you'd like to test the MSW, you can use the react queries in some file and check the network calls

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai added the DC Get Well Relating to the DC Get Well project label Nov 1, 2023
@coliu-akamai coliu-akamai self-assigned this Nov 1, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review November 1, 2023 15:45
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 1, 2023 15:45
@coliu-akamai coliu-akamai requested review from dwiley-akamai, hana-akamai and abailly-akamai and removed request for a team November 1, 2023 15:45
abailly-akamai
abailly-akamai approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks good, looks like everything we need to start development ✅

@mjac0bs mjac0bs added the @linode/api-v4 Changes are made to the @linode/api-v4 package label Nov 1, 2023
@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Nov 1, 2023
dwiley-akamai
dwiley-akamai approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left optional suggestions for the changeset entries, but everything else LGTM 🚢

packages/api-v4/.changeset/pr-9860-upcoming-features-1698852464578.md Outdated Show resolved Hide resolved
packages/manager/.changeset/pr-9860-upcoming-features-1698852576816.md Outdated Show resolved Hide resolved
coliu-akamai and others added 2 commits November 1, 2023 15:03
@coliu-akamai @dwiley-akamai
Update packages/manager/.changeset/pr-9860-upcoming-features-16988525…
717f8b8 
…76816.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
@coliu-akamai @dwiley-akamai
Update packages/api-v4/.changeset/pr-9860-upcoming-features-169885246…
5649f45 
…4578.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 1, 2023
@coliu-akamai coliu-akamai merged commit e9e4aef into linode:develop Nov 1, 2023
12 of 13 checks passed
@coliu-akamai coliu-akamai mentioned this pull request Nov 6, 2023
Closed
12 tasks
This was referenced Nov 8, 2023
Merged
Merged
@coliu-akamai coliu-akamai mentioned this pull request Nov 14, 2023
Merged
12 tasks
@coliu-akamai coliu-akamai deleted the feat-m3-7213 branch December 19, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

@hana-akamai hana-akamai Awaiting requested review from hana-akamai hana-akamai is a code owner automatically assigned from linode/frontend

Assignees

@coliu-akamai coliu-akamai

Labels
Approved Multiple approvals and ready to merge! DC Get Well Relating to the DC Get Well project @linode/api-v4 Changes are made to the @linode/api-v4 package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coliu-akamai @dwiley-akamai @abailly-akamai @mjac0bs