Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7399] - Linode Details - VPC Subnets Not Associated with VP… #9872

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Nov 3, 2023

Description πŸ“

Linode Details: VPC Subnets Not Associated with VPC IP Address Are Displayed.

Preview πŸ“·

Include a screenshot or screen recording of the change

πŸ’‘ Use <video src="" /> tag when including recordings in table.

Before After
image image

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • Checkout PR and run the app.
  • Point to dev.

Reproduction steps

(How to reproduce the issue, if applicable)

Verification steps

(How to verify changes)

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@cpathipa cpathipa added the VPC Relating to VPC project label Nov 3, 2023
@cpathipa cpathipa self-assigned this Nov 3, 2023
@cpathipa cpathipa requested a review from a team as a code owner November 3, 2023 19:24
@cpathipa cpathipa requested review from bnussman-akamai and abailly-akamai and removed request for a team November 3, 2023 19:24
@cpathipa cpathipa marked this pull request as draft November 3, 2023 19:24
@cpathipa cpathipa marked this pull request as ready for review November 3, 2023 19:36
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

confirmed only associated subnets show up βœ…

Also, before merging, you need another commit cause the e2e suite has not ran yet

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 7, 2023
@cpathipa cpathipa merged commit eb81e50 into linode:develop Nov 7, 2023
13 checks passed
@cpathipa cpathipa deleted the M3-7339 branch November 7, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants