fix: Restore nattedIPv4Address prop passed from LinodeConfigDialog --> InterfaceSelect
#9896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwiley-akamai
requested review from
cliu-akamai and
abailly-akamai
and removed request for
a team
| @@ -1005,15 +1005,16 @@ export const LinodeConfigDialog = (props: Props) => { | |||
| ipamAddress={thisInterface.ipam_address} | |||
| key={`eth${idx}-interface`} | |||
| label={thisInterface.label} | |||
| nattedIPv4Address={thisInterface.ipv4?.nat_1_1} | |||
There was a problem hiding this comment.
any reason for the prop not to be required?
There was a problem hiding this comment.
InterfaceSelect is used for non-VPC interfaces as well and used in contexts outside of the Add/Edit Config dialog. ipv4.nat_1_1 is only for VPC interfaces
hana-akamai
approved these changes
Nov 13, 2023
abailly-akamai
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We lost a one-liner added in #9865 that checks off the "Assign a public IPv4 address for this Linode" checkbox in the Edit Linode Config dialog when the
ipv4.nat_1_1property is populated. This PR restores it.How to test 🧪
Prerequisites
Reproduction steps
On the release branch:
configs) On the newly-created Linode, go to the Configurations tab, edit the config, scroll down the Edit Config dialog to the "Networking" section and observe: the VPC interface's "Assign a public IPv4 address for this Linode" checkbox is unchecked, despite the network request showingipv4.nat_1_1being populatedVerification steps
On this branch: