-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7423] - Create Bucket - Able to choose a single Compute Region ID eg ('us-east') #9976
Conversation
Coverage Report: ❌ |
…reate Drawer" This reverts commit be7305b.
… Region ID eg ('us-east')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature flag off & MSW disabled: existing functionality works as expected ✅
Feature flag on & MSW enabled: payload includes region
instead of cluster
and submission goes through ✅
Formatting of region options matches wireframes ✅
(did you want to update the copy for the Create Bucket drawer as part of this PR too?)
packages/manager/.changeset/pr-9976-upcoming-features-1702579922373.md
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/BucketRegions.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/CreateBucketDrawerObjMultiCluster.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/CreateBucketDrawerObjMultiCluster.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I tested the flow and did not find issues with payload and UI. Agreed with comments already added and left some other.
Also, you have duplicated keys console errors when opening the drawer with MSW enabled. It's previous to the PR and not affecting production code, but can be a bit misleading when testing so it would be nice to fix
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
…22373.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
…teBucketDrawerObjMultiCluster.tsx Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
…etRegions.tsx Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the changes.
- Code looks good ✅
- Confirmed seeing the right regions in the UI ✅
- Validation works as expected ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chandra, this is looking good! Left one question related to required field and validation, slightly tangential to this PR.
- Test are passing.
- Create Bucket region dropdown now shows regions instead of clusters.
- For regions with DC specific pricing, the overage costs are still correctly calculated.
- Existing Create Bucket functionality remains unchanged when feature flag is off.
- Mocked POST buckets submits and now includes the
region
rather than cluster.
Description 📝
OBJ Multi-Cluster - Create Bucket flow - Able to choose a single Compute Region ID eg ('us-east') instead of cluster ID.
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply