Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): support ssh://git@ protocol #124

Merged
merged 4 commits into from
Nov 17, 2023
Merged

fix(parser): support ssh://git@ protocol #124

merged 4 commits into from
Nov 17, 2023

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Nov 17, 2023

Regression Test

Platforms

  • windows
  • macOS
  • linux

Tasks

  • Use GitLink to copy git link.
  • Use GitLink! to open git link in browser.
  • Use GitLink blame to copy the /blame git link.
  • Use GitLink! blame to open the /blame git link in browser.
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

@github-actions github-actions bot added the fix label Nov 17, 2023
@linrongbin16
Copy link
Owner Author

relate: #114

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1236865) 79.97% compared to head (eee2d83) 77.25%.

Files Patch % Lines
lua/gitlinker/linker.lua 85.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   79.97%   77.25%   -2.73%     
==========================================
  Files          12       12              
  Lines         854      844      -10     
==========================================
- Hits          683      652      -31     
- Misses        171      192      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit 53c4efc into master Nov 17, 2023
8 checks passed
@linrongbin16 linrongbin16 deleted the fix-parser branch November 17, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant