-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: run podman directly instead of using containers.podman #196
Merged
ptoscano
merged 1 commit into
linux-system-roles:main
from
ptoscano:tests-using-podman-directly
Aug 7, 2024
Merged
tests: run podman directly instead of using containers.podman #196
ptoscano
merged 1 commit into
linux-system-roles:main
from
ptoscano:tests-using-podman-directly
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoscano
force-pushed
the
tests-using-podman-directly
branch
from
August 6, 2024 04:41
6f61196
to
1464a36
Compare
[citest] |
spetrosi
reviewed
Aug 6, 2024
ptoscano
force-pushed
the
tests-using-podman-directly
branch
from
August 6, 2024 12:00
1464a36
to
81d6117
Compare
[citest] |
ptoscano
force-pushed
the
tests-using-podman-directly
branch
from
August 6, 2024 12:24
81d6117
to
5851d27
Compare
[citest] |
ptoscano
force-pushed
the
tests-using-podman-directly
branch
from
August 6, 2024 12:45
5851d27
to
0ea8c9e
Compare
[citest] |
spetrosi
reviewed
Aug 6, 2024
Another way to dynamically construct lists in an assignment statement where you want to omit some of the elements is like this: - name: Start Candlepin container
command:
argv:
"{{ podman_run_cli }}"
changed_when: false
vars:
podman_run_cli: [podman, run, --rm, --detach, --hostname, candlepin_host, --name, candlepin, --publish,
8443:8443, --publish, 8080:8080] +
{{ ['--privileged'] if (ansible_distribution in ['CentOS', 'RedHat']
and ansible_distribution_major_version | int < 8)
else [] }} + [ghcr.io/ptoscano/candlepin-unofficial] Yes, it uses the "json" style of list definition, but I prefer readability to strict adherence of Ansible guidelines hmm - the indentation is way off - maybe github is auto-indenting something? |
Using the containers.podman collection to handle podman is a nice idea, however what that collection supports now is becoming more strict than what this role supports. Case in point: containers.podman now requires Python 3.6+ for the managed nodes, which breaks the testing of EL 7. This means that sadly the setup of a self-deployed Candlepin needs to run podman commands manually; use the proper parameters for "podman run" depending on the OS. The gymnastics of checking the return code & stderr of "podman stop" are needed because the "--ignore" option (which would be ideal) was introduced in podman 1.7.0, and EL 7 has podman 1.6.4. There is no behaviour change. Signed-off-by: Pino Toscano <ptoscano@redhat.com>
ptoscano
force-pushed
the
tests-using-podman-directly
branch
from
August 6, 2024 17:06
0ea8c9e
to
9a509b5
Compare
[citest] |
spetrosi
approved these changes
Aug 6, 2024
richm
reviewed
Aug 6, 2024
richm
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
containers.podman
collection to handlepodman
is a nice idea, however what that collection supports now is becoming more strict than what this role supports. Case in point:containers.podman
now requires Python 3.6+ for the managed nodes, which breaks the testing of EL 7.This means that sadly the setup of a self-deployed Candlepin needs to run
podman
commands manually; use the proper parameters forpodman run
depending on the OS.The gymnastics of checking the return code & stderr of
podman stop
are needed because the--ignore
option (which would be ideal) was introduced inpodman
1.7.0, and EL 7 haspodman
1.6.4.There is no behaviour change.