Add missing Build-Depends

[kelebek333]

Add missing Build-Depends: libgraphene-1.0-dev, gsettings-desktop-schemas-dev

[Fantu]

libgraphene-1.0-dev where is needed that I not found from a fast search?
gsettings-desktop-schemas-dev should not needed in build here but only gsettings-desktop-schemas already present in cinnamon dep.
Can you point to the code where there are needed please?

[kelebek333]

libgraphene-1.0-dev where is needed that I not found from a fast search?

../meson.build:24:0: ERROR: Could not generate cargs for muffin-clutter-0:
Package graphene-gobject-1.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `graphene-gobject-1.0.pc'
to the PKG_CONFIG_PATH environment variable
Package 'graphene-gobject-1.0', required by 'muffin-cogl-0', not found

gsettings-desktop-schemas already present in cinnamon dep.

This is not build-dep.

meson.build:40:0: ERROR: Could not generate cargs for libmuffin-0:
Package gsettings-desktop-schemas was not found in the pkg-config search path.
Perhaps you should add the directory containing `gsettings-desktop-schemas.pc'
to the PKG_CONFIG_PATH environment variable
Package 'gsettings-desktop-schemas', required by 'libmuffin-0', not found

pkg-config error with 'libmuffin-0': Could not generate cargs for libmuffin-0:
Package gsettings-desktop-schemas was not found in the pkg-config search path.
Perhaps you should add the directory containing `gsettings-desktop-schemas.pc'
to the PKG_CONFIG_PATH environment variable
Package 'gsettings-desktop-schemas', required by 'libmuffin-0', not found

[Fantu]

sry I don't saw that is about muffin rebase branch, in that I saw something about graphene in 618408a

[Fantu]

since you are "fixing" debian/control of muffin-5.2-test in this PR can you please also increase all muffin pkgs version to >=5.2 in build-deps and deps to avoid try to build/install with older muffin not compatible?

[Fantu]

after better check "missed" build-deps is caused by linuxmint/muffin@e3b579e merge of -dev packages without add -dev deps, in any case -dev packages should be separated to avoid install of many packages not needed for major of users

[kelebek333]

These are only depends of package building, are not depends of packages. Following files provides by dev packages.

Perhaps you should add the directory containing graphene-gobject-1.0.pc

Perhaps you should add the directory containing gsettings-desktop-schemas.pc

dpkg -S graphene-gobject-1.0.pc
libgraphene-1.0-dev:amd64: /usr/lib/x86_64-linux-gnu/pkgconfig/graphene-gobject-1.0.pc

dpkg -S gsettings-desktop-schemas.pc
gsettings-desktop-schemas-dev:amd64: /usr/share/pkgconfig/gsettings-desktop-schemas.pc

[Fantu]

@kelebek333 try to build with https://github.com/Fantu/muffin/tree/fix-5.2-test and https://github.com/Fantu/Cinnamon/tree/fix-muffin-5.2-test

[leigh123linux]

Muffin-5.2 requires gsettings-desktop-schemas and graphene-gobject-1.0 to compile not cinnamon

[kelebek333]

@leigh123linux , did you try build cinnamon without graphene-gobject-1.0 and gsettings-desktop-schemas? You can look following build logs.

Without libgraphene-1.0-dev and gsettings-desktop-schemas-dev

https://launchpadlibrarian.net/562595276/buildlog_ubuntu-focal-amd64.cinnamon_5.0.5+uma+5.2+rebase+testing_BUILDING.txt.gz

Without gsettings-desktop-schemas-dev

https://launchpadlibrarian.net/562627992/buildlog_ubuntu-focal-amd64.cinnamon_5.0.5+uma+5.2+rebase+testing1_BUILDING.txt.gz

[Fantu]

@kelebek333 the real issue is in muffin packages, try to build with my commits (see previous post)
another thing, I see https://launchpad.net/~kelebek333/+archive/ubuntu/muffin-3.36rebase-test seems you rebuild only new muffin and cinnamon on focal but is needed build also all other components updated because focal have older version

[leigh123linux]

@leigh123linux , did you try build cinnamon without graphene-gobject-1.0 and gsettings-desktop-schemas? You can look following build logs.

muffin-dev declares them in it's pkgconfig files so it should require them, see

$ rpm -qp --requires '/home/leigh/Desktop/test/muffin-devel-5.2-1.fc35.x86_64.rpm' 
/usr/bin/pkg-config
libmuffin.so.0()(64bit)
muffin(x86-64) = 5.2-1.fc35
pkgconfig(atk) >= 2.5.3
pkgconfig(cairo) >= 1.10.0
pkgconfig(cairo-gobject) >= 1.10.0
pkgconfig(egl)
pkgconfig(gio-unix-2.0) >= 2.61.1
pkgconfig(gl)
pkgconfig(glesv2)
pkgconfig(glib-2.0) >= 2.61.1
pkgconfig(gobject-2.0) >= 2.61.1
pkgconfig(graphene-gobject-1.0) >= 1.9.3
pkgconfig(gsettings-desktop-schemas) >= 3.33.0
pkgconfig(gtk+-3.0) >= 3.19.8
pkgconfig(json-glib-1.0) >= 0.12.0
pkgconfig(muffin-clutter-6)
pkgconfig(muffin-cogl-6)
pkgconfig(pango) >= 1.2.0
pkgconfig(x11)
pkgconfig(xfixes) >= 3
pkgconfig(xi) >= 1.7.4

Without libgraphene-1.0-dev and gsettings-desktop-schemas-dev

https://launchpadlibrarian.net/562595276/buildlog_ubuntu-focal-amd64.cinnamon_5.0.5+uma+5.2+rebase+testing_BUILDING.txt.gz

Without gsettings-desktop-schemas-dev

https://launchpadlibrarian.net/562627992/buildlog_ubuntu-focal-amd64.cinnamon_5.0.5+uma+5.2+rebase+testing1_BUILDING.txt.gz

[kelebek333]

@Fantu , If the libmuffin-dev's pull request will revert back, you are right, but else not.

For current, development packages should be added to Cinnamon.

I see https://launchpad.net/~kelebek333/+archive/ubuntu/muffin-3.36rebase-test seems you rebuild only new muffin and cinnamon on focal but is needed build also all other components updated because focal have older version

Linux Mint Daily Builds PPA is extra dependencies for my PPA. The PPA is not uses focal packages for Cinnamon.

muffin-dev declares them in it's pkgconfig files so it should require them, see

@leigh123linux ,

Currently, there is no libmuffin0-dev package for Debian control file on linuxmint:muffin-5.2-test branch. It migrated to libmuffin0. linuxmint/muffin@e3b579e If the commit will revert back, so this PR is not required.

apt depends libmuffin0
libmuffin0
Depends: muffin-common
Depends: libatk1.0-0
Depends: libc6
Depends: libcairo-gobject2
Depends: libcairo2
Depends: libcanberra-gtk3-0
Depends: libcanberra0
Depends: libegl1
Depends: libfontconfig1
Depends: libgdk-pixbuf2.0-0
Depends: libgirepository-1.0-1
Depends: libgl1
Depends: libglib2.0-0
Depends: libgtk-3-0
Depends: libice6
Depends: libjson-glib-1.0-0
Depends: libpango-1.0-0
Depends: libpangocairo-1.0-0
Depends: libpangoft2-1.0-0
Depends: libsm6
Depends: libstartup-notification0
Depends: libx11-6
Depends: libx11-xcb1
Depends: libxcb-res0
Depends: libxcomposite1
Depends: libxcursor1
Depends: libxdamage1
Depends: libxext6
Depends: libxfixes3
Depends: libxi6
Depends: libxinerama1
Depends: libxrandr2
Depends: libxrender1
Depends: libxtst6
Replaces: libmuffin-dev

[Fantu]

@kelebek333 about ppa sry I didn't saw dep on other ppa, now I'll try to build on another ppa with my commits using the same ppa dep

[leigh123linux]

Currently, there is no libmuffin0-dev package for Debian control file on linuxmint:muffin-5.2-test branch. It migrated to libmuffin0. linuxmint/muffin@e3b579e If the commit will revert back, so this PR is not required.

@clefebvre Is that commit just for testing?

[Fantu]

the bad thing packaging is also in muffin 5.0 probably clem simply did same of older version thinking to avoid possible regression but without calculate possible unexpected cases caused by this, -dev package separate and correctly don't do regression (only need a small change in cinnamon debian/control), we already use in debian packages, I already did the commits if clem want cherry-pick them (already posted in muffin PR post) and I have already tested: https://launchpad.net/~fantonifabio/+archive/ubuntu/muffin-rebase/
@kelebek333 in the ppa above build correctly fixing muffin packages without add other build-deps in cinnamon

[leigh123linux]

fixed linuxmint/muffin@5fdd790

[Fantu]

for now the commit is partial (debian/libmuffin-dev.install is missed) and is missed the commit in cinnamon to update build-deps
I rebased my branchs including latest clem and mtwebster fixes and added a missed break/replace in my commit to make working upgrade (also from any other 5.2 testing build installed because I didn't put the version for now) if someone want do a fast tests
https://github.com/Fantu/muffin/commits/fix-5.2-test
https://github.com/Fantu/Cinnamon/commits/fix-muffin-5.2-test
I tried to update my ppa (https://launchpad.net/~fantonifabio/+archive/ubuntu/muffin-rebase/) but cinnamon strange fails for muffin not found (even if is in same repository), yesteday also failed first time because muffin built package was published after long time but today seems too many time. Launchpad has it gotten worse lately? (I used it rarely lately)
edit: I created mint testing install, added "Linux Mint Daily Builds" ppa and my ppa but don't show my packages, after a check with apt-cache policy I found that is because "Linux Mint Daily Builds" have higher pinning
workaround, for example for install from my ppa:

sudo nano /etc/apt/preferences.d/fantu.pref

Package: *
Pin: release o=LP-PPA-fantonifabio-muffin-rebase
Pin-Priority: 700

edit2: build issue on launchpad was my stupid mistake, break/replace (of package splitted with file moved from another) when there is a dep on same package must have version (and must be minor that actual version of the package) or will be excluded making it uninstallable