Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System Monitor to right click panel when one is found #12134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

corbin-auriti
Copy link
Contributor

@corbin-auriti corbin-auriti commented Mar 27, 2024

This uses category heuristics similar to how we find Terminals for Preferred Applications setting
Also update system settings to use symbolic icon.
image

Purpose is quick access, feature parity with other desktop environments as a sane default for muscle memory

image
image

Forum Discussion and Poll:

https://forums.linuxmint.com/viewtopic.php?t=416628

@corbin-auriti
Copy link
Contributor Author

Also for reference a similar PR I made was declined before which had hard-coded options which was less ideal #10352

@mtwebster
Copy link
Member

Speaking of muscle memory, what about Cinnamon users' muscle memories? :)

Maybe putting it in troubleshooting would be safer? I know I use System Settings here constantly, others probably do as well - this makes it a bit crowded there.

and update system settings to use symbolic icon
@corbin-auriti
Copy link
Contributor Author

corbin-auriti commented Jun 11, 2024

@mtwebster Done, fair compromise
image

Pushed changes, and squashed the commits

@haggen88
Copy link
Contributor

This would be a very useful feature for those coming from Windows! It would be more intuitive than modifying the keyboard shortcuts, since in Cinnamon Ctrl+Alt+Delete is not used to launch the system monitor

menu.addMenuItem(new PopupMenu.PopupSeparatorMenuItem()); // separator line
menu.addMenuItem(menu.troubleshootItem);

this.addMenuItem(new SettingsLauncher(_("System Settings"), "", "preferences-desktop"));
this.addMenuItem(new SettingsLauncher(_("System Settings"), "", "system-run", "cinnamon-settings"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although working with the other icon themes I tested, the system-run icon presents something like a play icon for the breeze icon theme, so it might not be the best suited for System Settings there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants