Notifications@cinnamon.org : applet improvement #12234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new icon to panel when "Do not disturb" mod is enabled - New menu label when "Do not disturb" mod is enabled - Add a toggle switch to easily enable/disable notifications - Add an option to show/hide "Do not disturb" icon (when show empty tray option is disabled)
Add new icon for "Do not disturb" mod
Add an option to keep "do not disturb" icon on panel when show empty tray option is disabled
|
@Hilyxx Have you considered breaking this out into a separate applet? As a separate Spice, you would have much more flexibility for an implementation. |
|
Hello @rcalixte |
I don't see why not. It seems like the perfect solution actually. Similar to CinnaMenu as an alternative menu applet or the few window list ones. Having it separate means that you would have much more freedom with it and also fill a potential need if there are users that prefer an alternative. |
|
Ok, thanks @rcalixte, I will do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
When users enable "Do not disturb" mod, icon isn't updated on the panel.
This commit improves notifications applet with these changes :
Screencast.2024-06-14.04.42.26.webm