Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unsafe.Slice where possible #80

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Use unsafe.Slice where possible #80

merged 1 commit into from
Aug 26, 2022

Conversation

cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Aug 26, 2022

That's "safe" usage of "unsafe".

linxGnu
linxGnu approved these changes Aug 26, 2022
View reviewed changes
Copy link
Owner

@linxGnu linxGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you bro

@linxGnu
Copy link
Owner

linxGnu commented Aug 26, 2022

Could you please fix CI build @cuonglm Just need one type casting I guess

@cuonglm
Use unsafe.Slice where possible
c94b83b 
That's "safe" usage of "unsafe".
@cuonglm
Copy link
Contributor Author

cuonglm commented Aug 26, 2022

Could you please fix CI build @cuonglm Just need one type casting I guess

Done.

@linxGnu
Copy link
Owner

linxGnu commented Aug 26, 2022

Thank you very much

@linxGnu linxGnu merged commit b8d8d44 into linxGnu:master Aug 26, 2022
@kolinfluence kolinfluence mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linxGnu linxGnu linxGnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuonglm @linxGnu