fix(lambda): Set Cors header on GET requests (#865)

linz · Jul 6, 2020 · c3e3c4c · c3e3c4c
1 parent c3c4cdf
commit c3e3c4c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/packages/lambda/src/__test__/router.test.ts b/packages/lambda/src/__test__/router.test.ts
@@ -3,6 +3,7 @@ import { LambdaContext } from '../lambda.context';
 import { LambdaHttpResponse } from '../lambda.response';
 import { Router } from '../router';
 import { FakeLogger } from './log.spy';
+import { HttpHeader } from '../header';
 
 o.spec('router', () => {
     function makeContext(httpMethod: string, path: string): LambdaContext {
@@ -20,6 +21,7 @@ o.spec('router', () => {
 
         o(response.status).equals(200);
         o(response.statusDescription).equals('stub');
+        o(response.header(HttpHeader.Cors)).equals('*');
     });
 
     ['delete', 'post', 'head', 'put'].forEach((method) => {

diff --git a/packages/lambda/src/header.ts b/packages/lambda/src/header.ts
@@ -11,4 +11,5 @@ export const HttpHeader = {
     RateLimit: 'X-RateLimit-Limit',
     RateCount: 'X-RateLimit-Count',
     RateExpire: 'X-RateLimit-Expires',
+    Cors: 'Access-Control-Allow-Origin',
 };
diff --git a/packages/lambda/src/router.ts b/packages/lambda/src/router.ts
@@ -1,5 +1,6 @@
 import { LambdaContext } from './lambda.context';
 import { LambdaHttpResponse } from './lambda.response';
+import { HttpHeader } from './header';
 
 export type ReqCallback = (req: LambdaContext) => Promise<LambdaHttpResponse>;
 
@@ -10,7 +11,7 @@ export class Router {
         // Allow cross origin requests
         if (req.method === 'options') {
             return new LambdaHttpResponse(200, 'Options', {
-                'Access-Control-Allow-Origin': '*',
+                [HttpHeader.Cors]: '*',
                 'Access-Control-Allow-Credentials': 'false',
                 'Access-Control-Allow-Methods': 'OPTIONS,GET,PUT,POST,DELETE',
             });
@@ -26,7 +27,9 @@ export class Router {
             return new LambdaHttpResponse(404, 'Not Found');
         }
 
-        return await handler(req);
+        const response = await handler(req);
+        response.header(HttpHeader.Cors, '*');
+        return response;
     }
 
     get(path: string, handler: ReqCallback): void {