feat: add overview archive to imagery config #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 6 alerts when merging 1f0dc2b into e331835 - view on LGTM.com new alerts:
|
blacha
force-pushed
the
feat/use-overview-file
branch
from
c150bc1
to
82af401
Compare
epsgcodes default to the old NZTM when using epsg:2193
|
|
||
| export interface ConfigImageryOverview { | ||
| /** Path to overview archive */ | ||
| path: string; |
There was a problem hiding this comment.
This should be relative path?
There was a problem hiding this comment.
Can we update the comment to say this is a relative path from the imagery.uri?
There was a problem hiding this comment.
interesting thought, maybe we should check if it starts with ./ then join it or allow it to be absolute? s3://foo/bar/overviews
There was a problem hiding this comment.
That would be better. I would like to have the option to put overview in different location.
Wentao-Kuang
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.