Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Enable 3d screenshots in the basemaps. BM-1054 #3317

Merged
merged 20 commits into from
Aug 15, 2024
Merged

ci: Enable 3d screenshots in the basemaps. BM-1054 #3317

merged 20 commits into from
Aug 15, 2024

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Jul 11, 2024 •
edited
Loading

Motivation

We want to fix the 3d screenshots in PR.

Modifications

  • When setting 3d in screenshots, we want to force load config from url and wait for 2s.
  • Updated to the latest screenshot cli which removes bearing and pitch to save computing.
  • Only do 5 tests on 3d map screenshots to keep the workflow running around 4 mins.
  • Stop showing debug.terrain and debug.terrain in url when it is off

Verification

@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner July 11, 2024 21:27
@Wentao-Kuang Wentao-Kuang requested a review from blacha July 11, 2024 21:27
@blacha blacha added this pull request to the merge queue Aug 15, 2024
Merged via the queue into master with commit 1655ea3 Aug 15, 2024
11 checks passed
@blacha blacha deleted the feat/3d-screenshot branch August 15, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wentao-Kuang @blacha