fix(landing): Fix the zoom to extend by using maplibre to adjust AntiMeridian. BM-1155 #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also tested this locally. The 'zoom to layer' function now works again as expected. The failing visual snapshot tests appear to be changes made to the topographic imagery, not something affected by this work. Approving this pull request now. |
tawera-manaena
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The zoom to extend feature is broken after upgrade the maplibre to latest release. It always zoom back to the whole world when switching layer, seems the caused by the anti Meridian. And this only happens to the Web Mercator
Modifications
Maplibre got a fix of adjustAntiMeridian between v4.5 to v4.71.
I believe that causes some conflicts with the pre-adjust in our system, and this is fixed after we do a
maplibre.LngLatBounds.convertfor Web Mercator as well.Verification
Local tested, all zoom to layer working fine for Web Mercator and NZTM now.