feat: add and use current datetime and odr_url for standardising TDE-1318 #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
paulfouquet
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
📣 this requires `v6` of `topo-imagery` to be released 📣 #### Motivation - [TDE-1289: Add a slug to the collection.json for use by Basemaps and when creating ODR paths](https://toitutewhenua.atlassian.net/browse/TDE-1283) #### Modification - Replace the existing `collection-id` argument parameter with `odr_url` to provide a path to existing metadata. - Create a `stac-setup` task to use the Argo Tasks `stac-setup` command to create the following metadata for the downstream tasks `standardise-validate` and `create-collection` to use: - `collection_id` - `linz_slug` (Note that the timestamp workflow change is implemented in [separate PR #856](#856)).  #### Checklist - [ ] Tests updated - tested manually using custom workflow - [x] Docs updated - [x] Issue linked in Title
amfage
requested review from
l0b0,
schmidtnz,
MDavidson17,
paulfouquet and
Wentao-Kuang
paulfouquet
approved these changes
Nov 14, 2024
l0b0
approved these changes
Nov 14, 2024
| @@ -413,6 +413,8 @@ spec: | |||
| value: '{{item}}' | |||
| - name: collection_id | |||
| value: '{{tasks.stac-setup.outputs.parameters.collection_id}}' | |||
| - name: current_datetime | |||
| value: '{{tasks.stac-setup.finishedAt}}' | |||
There was a problem hiding this comment.
If I understand correctly based on our discussion, the pros of this are:
- Short
- Doesn't require any extra code in the
stac-setuptask
Cons:
- If the
finishedAtformat/semantics changes in the future, this could break workflows in hard-to-predict ways
It's probably a reasonable assumption that this won't change very soon, since it's a value that's probably used my a lot of production code elsewhere.
amfage
added a commit
that referenced
this pull request
Nov 14, 2024
📣 this requires `v6` of `topo-imagery` to be released 📣 #### Motivation - [TDE-1289: Add a slug to the collection.json for use by Basemaps and when creating ODR paths](https://toitutewhenua.atlassian.net/browse/TDE-1283) #### Modification - Replace the existing `collection-id` argument parameter with `odr_url` to provide a path to existing metadata. - Create a `stac-setup` task to use the Argo Tasks `stac-setup` command to create the following metadata for the downstream tasks `standardise-validate` and `create-collection` to use: - `collection_id` - `linz_slug` (Note that the timestamp workflow change is implemented in [separate PR #856](#856)).  #### Checklist - [ ] Tests updated - tested manually using custom workflow - [x] Docs updated - [x] Issue linked in Title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 to be merged only once the relevant work on TDE-1129 has been completed and released 📣
This Pull Request builds on Pull Request #884 that adds the
stac-setupstep and related parameters for thelinz:slug.Motivation
Modification
standardise-validateto use theodr_urlworkflow parameter as--published-pathinput.standardise-validateto use thecollection_idparameter from thestac-setuptask.standardise-validateas--current-datetime.Checklist