Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

backend validation is not strict enough for coordinates input #1081

Open
MagdaN opened this issue May 6, 2015 · 4 comments
Open

backend validation is not strict enough for coordinates input #1081

MagdaN opened this issue May 6, 2015 · 4 comments
Labels
backend bug upstream

Comments

@MagdaN
Copy link
Contributor

MagdaN commented May 6, 2015

creating a kiezkassenproposal without adding a geolocation used to work but does not anymore - these are the errors:

description: ""<colander._drop object at 0x7fc538e31390>" is not a number"
location: "body"
name: "coordinates.0"

description: ""<colander._drop object at 0x7fc538e31390>" is not a number"
location: "body"
name: "coordinates.1"

Adding a marker/pin to the map is supposed to be optional.
@MagdaN MagdaN added the backend label May 6, 2015
@xi xi added the prio: high label May 11, 2015
@xi
Copy link
Collaborator

xi commented May 11, 2015

The errors mentioned above happen on GET. POST responds with a 200 status.

@pallix pallix added the bug label May 12, 2015
@pallix
Copy link
Collaborator

pallix commented May 12, 2015

The frontend should not POST a value of coordinates: [null, null] but either nothing or coordinates: [0,0] to set the default value.

The backend need to be fixed and reject such requests.

@xi xi added the frontend label May 13, 2015
@xi xi self-assigned this May 13, 2015
xi pushed a commit that referenced this issue May 13, 2015
do not post empty point in kiezkassen proposal (see #1081)
ffdca46
@xi
Copy link
Collaborator

xi commented May 13, 2015

The frontend part is fixed in #1129

@xi xi removed their assignment May 13, 2015
MagdaN added a commit that referenced this issue May 13, 2015
@MagdaN
Merge pull request #1129 from liqd/2015-05-tb-do-not-post-empty-point
53345ff 
do not post empty point in kiezkassen proposal (see #1081)
@pallix
Copy link
Collaborator

pallix commented May 18, 2015

Colander issue 224 and 225 should help to fix it Pylons/colander#224 Pylons/colander#225

@pallix pallix changed the title cant create proposal without pin anymore backend validation is not strict enough for coordinates input May 19, 2015
@pallix pallix mentioned this issue Jul 29, 2015
Closed
xi pushed a commit that referenced this issue Jul 29, 2015
Fix rm marker
24ce4cb 
This fixes an issue connected to #1081 that appeareds when you first
create a map marker and then remove it again (still in the create
dialog).
xi pushed a commit that referenced this issue Jul 29, 2015
Fix rm marker
4ea3ee9 
This fixes an issue connected to #1081 that appeareds when you first
create a map marker and then remove it again (still in the create
dialog).
@xi xi mentioned this issue Jul 29, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
backend bug upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xi @pallix @MagdaN