-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make this library compatible with SQL #62
fix: make this library compatible with SQL #62
Conversation
…he pom should not break Liquibase working with SQL databases)
I understand PRs can take some times. How soon will you be able to check it ? |
Hello @ylacaute. Thank you for submitting this PR. Your changes definitely makes sense, i'll try to test it by the end of this week. |
Hey, @ylacaute i changed your test to be Spock one, as extension already use Spock and it's general direction where whole Liquibase test infrastructure is moving. Also made check in test a bit more obvious. If you are fine with those changes we can merge this PR |
➤ Kristyl Gomes commented: Assigning this ticket to Oleh Kushniryk who has reviewed and improved the PR. |
3 similar comments
➤ Kristyl Gomes commented: Assigning this ticket to Oleh Kushniryk who has reviewed and improved the PR. |
➤ Kristyl Gomes commented: Assigning this ticket to Oleh Kushniryk who has reviewed and improved the PR. |
➤ Kristyl Gomes commented: Assigning this ticket to Oleh Kushniryk who has reviewed and improved the PR. |
Yes of course ! If you prefer to keep spoke, do as you please ! I undertand you want to keep a single test framework. |
Also, please note that my comment on my test is not very good. This PR fixes 2 others conflicts with generators (I think, don't remember how many), maybe we should remove the comment which is incomplete and finaly not very usefull. |
Hi @ylacaute -- the spock tests are not run via |
Adding the cassandra extension in the classpath currently breaks any existing Liquibase config working with SQL databases. Indeed, Liquibase initializes many things by searching in the classPath, and some generators are taken from Cassandra extension even when we are working on a true SQL database.
This commit fixes this unexpected behaviour and allows to configure a single project working with a true SQL database and Cassandra, at the same time.
┆Issue is synchronized with this Jira Bug by Unito