Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liquibase cassandra #52

Closed
wants to merge 3 commits into from

Conversation

maximevw
Copy link
Contributor

@maximevw maximevw commented Nov 18, 2023

Following the driver swap from Simba JDBC to ING JDBC driver in cassandra-liquibase 4.25.0, it sounds good to me to update the documentation in accordance with this change.

following the driver swap from Simba JDBC to ING JDBC driver in
cassandra-liquibase 4.25.0
@maximevw
Copy link
Contributor Author

Note these changes could only be valid if the issue liquibase/liquibase-cassandra#242 is fixed first.

@maximevw
Copy link
Contributor Author

maximevw commented Dec 7, 2023

Note these changes could only be valid if the issue liquibase/liquibase-cassandra#242 is fixed first.

Since the fix has been released in 4.25.0.1, I updated the versions in this PR.

kevin-atx added a commit that referenced this pull request Dec 8, 2023
updated cassandra JDBC strings using guidance from PR #52
@kevin-atx
Copy link
Contributor

kevin-atx commented Dec 8, 2023

.

@kevin-atx
Copy link
Contributor

I made many changes to the Cassandra pages over the past couple of weeks. So, I went ahead and manually merged your updates into PR #59

Please review the pages when you can and either let me know of any errors or submit a PR with any remaining changes. I'll keep an eye out for any tickets from you.

Here are the links to the page (for your convenience):

If you would send me an email at kevin@liquibase.com, I'd like to invite you (and your team) to a Liquibase Contributor slack channel for Cassandra. This would make it easier for us to interact in real-time, when needed.

Thanks again for all of your help.

@kevin-atx kevin-atx closed this Dec 8, 2023
@maximevw
Copy link
Contributor Author

maximevw commented Dec 8, 2023

Hello @kevin-atx,

Thank you for the update! (I appreciated the new format, more readable and using variables for versions or common sections is a very good idea 👍🏻 )

I suggested few small changes in the PR #60. I let you review them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants