Skip to content

Commit

Permalink
DAT-17565 DevOps :: localstack failing for aws-aurora 8 in test-harne…
Browse files Browse the repository at this point in the history
…ss (#797)

* ci(aws.yml): add commands to check versions of aws, pip, and awslocal for debugging purposes

* build(aws.yml): add installation steps for AWS CLI to the GitHub Actions workflow to enable AWS CLI usage in the workflow.

* fix(aws.yml): update aws-cli installation command to include bin-dir, install-dir, and update options for better configuration and maintenance

* fix(aws.yml): update Python version to '3.11.5' for compatibility with setup-python action
refactor(aws.yml): remove unnecessary AWS CLI and pip version checks from the workflow
fix(aws.yml): remove engine version parameter in 'awslocal rds create-db-cluster' command for aurora-mysql to match the command syntax

* chore(aws.yml): remove unnecessary RDS_MYSQL_DOCKER environment variable to clean up workflow configuration

* fix(aws.yml): update engine version parameter in create-db-cluster command to use TH_AURORA_MYSQL_ENGINE environment variable for consistency

* chore(aws.yml): add RDS_MYSQL_DOCKER environment variable to enable MySQL engine in LocalStack
fix(aws.yml): remove unnecessary engine version parameter in create-db-cluster command for Aurora MySQL to prevent errors

* chore(aws.yml): remove unnecessary TH_AURORA_MYSQL_ENGINE variable assignment

* chore(aws.yml): add TH_AURORA_MYSQL_ENGINE variable to set the engine version for Aurora MySQL

* chore(aws.yml): remove TH_AURORA_MYSQL_ENGINE variable as it is no longer needed
  • Loading branch information
jandroav authored Apr 25, 2024
1 parent a2617da commit cf78bec
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/aws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ jobs:
echo "TH_DB_PASSWD=test" >> $GITHUB_ENV
echo "TH_DB_PASSWD_MSSQL=Test.2024" >> $GITHUB_ENV
echo "TH_DB=lbcat" >> $GITHUB_ENV
echo "TH_AURORA_MYSQL_ENGINE=8.0" >> $GITHUB_ENV
echo "TH_AURORA_POSTGRESQL_ENGINE=16" >> $GITHUB_ENV
echo "TH_MARIADB_ENGINE=10.6" >> $GITHUB_ENV
echo "TH_MSSQL_ENGINE=2019" >> $GITHUB_ENV
Expand All @@ -101,7 +100,7 @@ jobs:
- name: Init Aurora MySQL Database
if: ${{ steps.setup.outputs.databasePlatform == 'mysql' && steps.setup.outputs.databaseVersion == 'aurora' }}
run: |
awslocal rds create-db-cluster --db-cluster-identifier aurora-mysql-primary-cluster --engine aurora-mysql --engine-version ${{ env.TH_AURORA_MYSQL_ENGINE }} --database-name ${{ env.TH_DB }} --master-username ${{ env.TH_DB_ADMIN }} --master-user-password ${{ env.TH_DB_PASSWD }}
awslocal rds create-db-cluster --db-cluster-identifier aurora-mysql-primary-cluster --engine aurora-mysql --database-name ${{ env.TH_DB }} --master-username ${{ env.TH_DB_ADMIN }} --master-user-password ${{ env.TH_DB_PASSWD }}
awslocal rds create-db-instance --db-instance-identifier aurora-mysql-primary-cluster-instance --db-cluster-identifier aurora-mysql-primary-cluster --engine aurora-mysql --db-instance-class db.t3.medium
aurora_mysql_port=$(awslocal rds describe-db-instances --db-instance-identifier aurora-mysql-primary-cluster-instance --query 'DBInstances[0].Endpoint.Port' | jq -r)
aurora_mysql_url="jdbc:mysql://localhost:$aurora_mysql_port/${{ env.TH_DB }}"
Expand Down

0 comments on commit cf78bec

Please sign in to comment.