Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uid related issues #367

Merged
merged 2 commits into from
Jan 26, 2022
Merged

fix: uid related issues #367

merged 2 commits into from
Jan 26, 2022

Conversation

yitsushi
Copy link
Contributor

What this PR does / why we need it:

  • e2e path was not updated.
  • Get tried to use empty name and namespace as a filter, not it does not
    use those values if they are empty.
  • UpdateMicroVM required all fields.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Related to #291 (issue)
Related to #327 (pr)

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@yitsushi
fix: uid related issues
5d0281d 
* e2e path was not updated.
* Get tried to use empty name and namespace as a filter, not it does not
  use those values if they are empty.
* UpdateMicroVM required all fields.

Related to #291 (issue)
Related to #327 (pr)
@yitsushi yitsushi added the kind/bug Something isn't working label Jan 26, 2022
@yitsushi
Copy link
Contributor Author 

--- PASS: TestE2E (44.65s)
PASS
ok      github.com/weaveworks/flintlock/test/e2e        44.658s
?       github.com/weaveworks/flintlock/test/e2e/utils  [no test files]

Callisto13
Callisto13 previously approved these changes Jan 26, 2022
View reviewed changes
@yitsushi yitsushi merged commit 74e4999 into main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yitsushi @Callisto13