-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does .lockfile-lint.js config work? #192
Comments
About the config file loader - we're using cosmiconfig in the project and it appears that some naming conventions work, and others don't for some reason but I didn't check why. Works:
If you wanted to update the README for the project with this information and examples, I'm happy to merge the PR so it is more helpful to other users in the future. As for the types - if you want to contribute that in a PR as well, I'm happy to land it. |
I fixed my issue; it was a small error in the documentation. See #193. Would you mind updating to the latest release of cosmiconfig: https://github.com/cosmiconfig/cosmiconfig/releases/tag/v9.0.0 |
Ahh yes! Good catch. I'll also shoot out a new release for the cosmiconfig dependency in a bit. |
@lirantal I noticed that cosmiconfig still is pinned on version 8, and not yet updated to v9.
|
Sorry for the delay, @jerone Let me know if there are still any pending issues. |
The documentation states that it's possible to define a config with the following filenames
.lockfile-lint.js
orlockfilelint.config.js
. Per convention it should return a JavaScript object.However, it seems to not work. When running
lockfile-lint
with one of the examples below, it errors with the following message:I've tried the following config:
or
When I try a JSON config (e.g.
.lockfile-lintrc
) it just works.It also appears there is no
@types
for the config. Not in the package or as a separate npm package. There is an@types/lockfile-lint-api
package, but it's only for the API, not the config. I would like to use the types in the JavaScript configs:The text was updated successfully, but these errors were encountered: