Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Simplification of isolated nodes #210

Closed
lucaneg opened this issue Jul 21, 2022 · 0 comments · Fixed by #211
Closed

[BUG] Simplification of isolated nodes #210

lucaneg opened this issue Jul 21, 2022 · 0 comments · Fixed by #211
Assignees
@lucaneg
Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🏛 scope:program-structure Work regarding the program structure 🐛 type:bug Something isn't working
Milestone
0.1b6

Comments

@lucaneg
Copy link
Member

lucaneg commented Jul 21, 2022 •
edited
Loading

Description
1)
When a NodeList has the following form:

0: <(i, 3) [out: [ <(i, 3) ] -T-> [ Open block: 'go-testcases/cfg/return/go-return.go':7:10 ], [ <(i, 3) ] -F-> [ Open block: 'go-testcases/cfg/return/go-return.go':9:8 ]]
-----
3: no-op
-----
4: Open block: 'go-testcases/cfg/return/go-return.go':7:10 [in: [ <(i, 3) ] -T-> [ Open block: 'go-testcases/cfg/return/go-return.go':7:10 ]]
5: return 1
-----
7: Open block: 'go-testcases/cfg/return/go-return.go':9:8 [in: [ <(i, 3) ] -F-> [ Open block: 'go-testcases/cfg/return/go-return.go':9:8 ]]
8: return 2

Simplifying the no-op will not recompute cutoffs accordingly.
@lucaneg lucaneg added 🐛 type:bug Something isn't working ‼ priority:p1 Priority planning - level 1 🏛 scope:program-structure Work regarding the program structure labels Jul 21, 2022
@lucaneg lucaneg added this to the 0.1b6 milestone Jul 21, 2022
@lucaneg lucaneg self-assigned this Jul 21, 2022
@lucaneg lucaneg changed the title [BUG] Missing offset recomputation when simplifying isolated nodes [BUG] Simplification of isolated nodes Jul 21, 2022
lucaneg added a commit that referenced this issue Jul 21, 2022
@lucaneg
Adding test for #210
81a265d
lucaneg added a commit that referenced this issue Jul 21, 2022
@lucaneg
Fixing cutoff recomputation #210
664bcfe
@lucaneg lucaneg mentioned this issue Jul 21, 2022
Merged
@lucaneg lucaneg added the 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaneg lucaneg

Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🏛 scope:program-structure Work regarding the program structure 🐛 type:bug Something isn't working
Projects
None yet
Milestone
0.1b6
Development

Successfully merging a pull request may close this issue.

Cutoff recomputation in NodeList lisa-analyzer/lisa
1 participant
@lucaneg