Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Implement NumericNonOverflowingMod in Interval domain #216

Closed
simonegazza opened this issue Oct 26, 2022 · 1 comment · Fixed by #234
Closed

[FEATURE REQUEST] Implement NumericNonOverflowingMod in Interval domain #216

simonegazza opened this issue Oct 26, 2022 · 1 comment · Fixed by #234
Assignees
@lucaneg
Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms 🎆 type:feature New feature or request
Milestone
0.1b7

Comments

@simonegazza
Copy link

simonegazza commented Oct 26, 2022 •
edited
Loading

Description
It seems that NumericNonOverflowingMod always returns top when using the interval domain.

Motivation
This kind of operator in particular is also used in rust-lisa; also further expansion of arithmetic operations should improve some analysis.
@simonegazza simonegazza added the 🎆 type:feature New feature or request label Oct 26, 2022
@VincenzoArceri VincenzoArceri changed the title [FEATURE REQUEST] Implement NumericNonOverflowingMod [FEATURE REQUEST] Implement NumericNonOverflowingMod in Interval domains Oct 28, 2022
@VincenzoArceri VincenzoArceri changed the title [FEATURE REQUEST] Implement NumericNonOverflowingMod in Interval domains [FEATURE REQUEST] Implement NumericNonOverflowingMod in Interval domain Oct 28, 2022
@VincenzoArceri
Copy link
Collaborator

Instead of returning TOP, we could return the interval [0, +Inf].

@lucaneg lucaneg removed their assignment Oct 28, 2022
@lucaneg lucaneg assigned lucaneg and unassigned simonegazza Nov 4, 2022
@lucaneg lucaneg added this to the 0.1b7 milestone Nov 4, 2022
lucaneg added a commit that referenced this issue Nov 7, 2022
@lucaneg
Semantics for modulo and remainder #216
7964176
@lucaneg lucaneg added the 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet label Nov 7, 2022
@lucaneg lucaneg mentioned this issue Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaneg lucaneg

Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms 🎆 type:feature New feature or request
Projects
LiSA
Archived in project
Milestone
0.1b7
Development

Successfully merging a pull request may close this issue.

Beta7 lisa-analyzer/lisa
3 participants
@VincenzoArceri @lucaneg @simonegazza