Filename sanitization for FileManager
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Unit Test Results 33 files 33 suites 8s ⏱️ Results for commit 23e4179. |
This comment has been minimized.
This comment has been minimized.
Cron Test Results10 files 10 suites 3s ⏱️ Results for commit 23e4179. |
pietroferrara
approved these changes
Oct 1, 2021
lucaneg
added
the
🏨 scope:infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FileManagerwas implemented such that slashes in filenames were always considered intentional, meaning that a sub-directory needed to be created. This is not always the case: java bytecode signatures contain slashes, and if those signatures are used in file names (i.e. dot files) this caused unwanted creation of sub-folders.Fixed bugs
Closes #130